patch[python]: Use multipart EP for feedback creation (#1655)

### Purpose
All feedback ingest should go through multipart, in order to do this, we
need to set the`trace_id`.

Author: angus-langchain

python/langsmith/testing/_internal.py

@@ -464,13 +464,13 @@ def _end_tests(test_suite: _LangSmithTestSuite):
         test_suite.client.update_dataset_tag(
             dataset_id=dataset_id,
             as_of=dataset_version,
-            tag=f'git:commit:{git_info["commit"]}',
+            tag=f"git:commit:{git_info['commit']}",
         )
     if dataset_version and git_info["branch"] is not None:
         test_suite.client.update_dataset_tag(
             dataset_id=dataset_id,
             as_of=dataset_version,
-            tag=f'git:branch:{git_info["branch"]}',
+            tag=f"git:branch:{git_info['branch']}",
         )
 
 
@@ -560,7 +560,9 @@ def submit_result(
         self._executor.submit(self._submit_result, run_id, score)
 
     def _submit_result(self, run_id: uuid.UUID, score: Optional[int]) -> None:
-        self.client.create_feedback(run_id, key="pass", score=score)
+        # trace_id will always be run_id here because the feedback is on the root
+        # test run
+        self.client.create_feedback(run_id, key="pass", score=score, trace_id=run_id)
 
     def sync_example(
         self,
@@ -635,7 +637,9 @@ def _submit_feedback(
             )
 
     def _create_feedback(self, run_id: ID_TYPE, feedback: dict, **kwargs: Any) -> None:
-        self.client.create_feedback(run_id, **feedback, **kwargs)
+        # trace_id will always be run_id here because the feedback is on the root
+        # test run
+        self.client.create_feedback(run_id, **feedback, **kwargs, trace_id=run_id)
 
     def shutdown(self):
         self._executor.shutdown()
@@ -914,10 +918,11 @@ def _test():
             "reference_example_id": str(test_case.example_id),
         },
     }
-    with rh.tracing_context(
-        **{**current_context, "metadata": metadata}
-    ), ls_utils.with_optional_cache(
-        cache_path, ignore_hosts=[test_case.test_suite.client.api_url]
+    with (
+        rh.tracing_context(**{**current_context, "metadata": metadata}),
+        ls_utils.with_optional_cache(
+            cache_path, ignore_hosts=[test_case.test_suite.client.api_url]
+        ),
     ):
         _test()
 
@@ -982,10 +987,11 @@ async def _test():
             "reference_example_id": str(test_case.example_id),
         },
     }
-    with rh.tracing_context(
-        **{**current_context, "metadata": metadata}
-    ), ls_utils.with_optional_cache(
-        cache_path, ignore_hosts=[test_case.test_suite.client.api_url]
+    with (
+        rh.tracing_context(**{**current_context, "metadata": metadata}),
+        ls_utils.with_optional_cache(
+            cache_path, ignore_hosts=[test_case.test_suite.client.api_url]
+        ),
     ):
         await _test()
 
@@ -1020,9 +1026,7 @@ def test_foo() -> None:
                 assert foo(x, y) == 2
     """
     if ls_utils.test_tracking_is_disabled():
-        logger.info(
-            "LANGSMITH_TEST_TRACKING is set to 'false'." " Skipping log_inputs."
-        )
+        logger.info("LANGSMITH_TEST_TRACKING is set to 'false'. Skipping log_inputs.")
         return
     run_tree = rh.get_current_run_tree()
     test_case = _TEST_CASE.get()
@@ -1064,9 +1068,7 @@ def test_foo() -> None:
                 assert result == 2
     """
     if ls_utils.test_tracking_is_disabled():
-        logger.info(
-            "LANGSMITH_TEST_TRACKING is set to 'false'." " Skipping log_outputs."
-        )
+        logger.info("LANGSMITH_TEST_TRACKING is set to 'false'. Skipping log_outputs.")
         return
     run_tree = rh.get_current_run_tree()
     test_case = _TEST_CASE.get()
@@ -1110,8 +1112,7 @@ def test_foo() -> None:
     """
     if ls_utils.test_tracking_is_disabled():
         logger.info(
-            "LANGSMITH_TEST_TRACKING is set to 'false'."
-            " Skipping log_reference_outputs."
+            "LANGSMITH_TEST_TRACKING is set to 'false'. Skipping log_reference_outputs."
         )
         return
     test_case = _TEST_CASE.get()
@@ -1164,9 +1165,7 @@ def test_foo() -> None:
                 assert result == expected
     """
     if ls_utils.test_tracking_is_disabled():
-        logger.info(
-            "LANGSMITH_TEST_TRACKING is set to 'false'." " Skipping log_feedback."
-        )
+        logger.info("LANGSMITH_TEST_TRACKING is set to 'false'. Skipping log_feedback.")
         return
     if feedback and any((key, score, value)):
         msg = "Must specify one of 'feedback' and ('key', 'score', 'value'), not both."
@@ -1270,9 +1269,7 @@ def test_openai_says_hello():
                 assert "hello" in response.choices[0].message.content.lower()
     """  # noqa: E501
     if ls_utils.test_tracking_is_disabled():
-        logger.info(
-            "LANGSMITH_TEST_TRACKING is set to 'false'." " Skipping log_feedback."
-        )
+        logger.info("LANGSMITH_TEST_TRACKING is set to 'false'. Skipping log_feedback.")
         yield None
         return
     parent_run = rh.get_current_run_tree()

python/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "langsmith"
-version = "0.3.29"
+version = "0.3.30"
 description = "Client library to connect to the LangSmith LLM Tracing and Evaluation Platform."
 authors = ["LangChain <[email protected]>"]
 license = "MIT"