Suggestion: allow telnet line endings to be parameterised

[kazkansouh]

Hello,

I was just using the Telnet module against a Windows server. However, currently it is hard coded to send a \n at the end of the input sequences. The server however was not accepting it and instead required a \r instead.

I have confirmed that both using the telnet command line client does this and so does Hyda. Looking at the code below it looks like this has been considered but changed for some reason:

patator/patator.py

Line 2648 in 0d7661b

cmd = b(val + '\n') #'\r\x00'

Taking a quick look at RFC 854 states at the end of page 11 (I haven't read it in depth, so could be mistaken):

Note that "CR LF" or "CR NUL" is required in both directions (in the default ASCII mode).

Regardless, I think it would probably make sense to allow this to be parameterised to improve compatibility with more systems?

[lanjelot]

Thanks for this, can you please submit a patch? :)