Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9 support? #14

Open
snipe opened this issue Jul 27, 2022 · 1 comment
Open

Laravel 9 support? #14

snipe opened this issue Jul 27, 2022 · 1 comment

Comments

@snipe
Copy link

snipe commented Jul 27, 2022

Hi there - thanks so much for this great package! I was wondering if there is any plan to update it to work with Laravel 9? Seems like illuminate/support now conflicts with Laravel itself.

✨snipe@chodeblossom✨ corporate  (features/upgrade_cashier) $ composer update
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - illuminate/support[v5.6.0, ..., v5.8.36] require php ^7.1.3 -> your php version (8.0.8) does not satisfy that requirement.
    - illuminate/support[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.8) does not satisfy that requirement.
    - illuminate/support[v7.0.0, ..., v7.28.4] require php ^7.2.5 -> your php version (8.0.8) does not satisfy that requirement.
    - illuminate/support[v8.0.0, ..., v8.11.2] require php ^7.3 -> your php version (8.0.8) does not satisfy that requirement.
    - Root composer.json requires laravel-notification-channels/pagerduty ^0.4.0 -> satisfiable by laravel-notification-channels/pagerduty[0.4.0].
    - Conclusion: don't install laravel/framework v9.0.2 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.1.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.2.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.3.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.3.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.4.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.4.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.5.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.5.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.6.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.7.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.8.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.8.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.9.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.10.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.10.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.11.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.12.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.12.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.12.2 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.13.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.14.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.14.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.15.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.16.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.17.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.18.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.19.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.20.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.21.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.21.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.21.2 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.21.3 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.21.4 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.21.5 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.21.6 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.22.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.22.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v9.0.1 (conflict analysis result)
    - laravel-notification-channels/pagerduty 0.4.0 requires illuminate/support ~5.5 || ~6.0 || ~7.0 || ^8.0 -> satisfiable by illuminate/support[v5.5.0, ..., v5.8.36, v6.0.0, ..., v6.20.44, v7.0.0, ..., v7.30.6, v8.0.0, ..., v8.83.23].
    - Only one of these can be installed: illuminate/support[v5.1.1, ..., v5.8.36, v6.0.0, ..., v6.20.44, v7.0.0, ..., v7.30.6, v8.0.0, ..., v8.83.23, v9.0.0, ..., v9.22.1], laravel/framework[v9.0.0, ..., v9.22.1]. laravel/framework replaces illuminate/support and thus cannot coexist with it.
    - Root composer.json requires laravel/framework ^9.0 -> satisfiable by laravel/framework[v9.0.0, ..., v9.22.1].

It’s possible we can just pull that requirement out of the composer.json, since it seems it’s replaced in Laravel 9. I can give this a try on a fork and see if it works, if that would be helpful.

Thanks again for your time!

@snipe
Copy link
Author

snipe commented Jul 28, 2022

Ack, just noticed there is already a PR up for this: #13 - so sorry for the duplication. :(

Any change of that getting merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant