Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exiting the "app:build" command removes/clears the "box.json" file #338

Open
nunomaduro opened this issue Mar 17, 2021 · 4 comments · May be fixed by laravel-zero/framework#501
Open

Exiting the "app:build" command removes/clears the "box.json" file #338

nunomaduro opened this issue Mar 17, 2021 · 4 comments · May be fixed by laravel-zero/framework#501

Comments

@nunomaduro
Copy link
Member

Just noticed that if we leave the command "app:build" with a control + C, that actually clears the "box.json" file.

➜ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
➜ php laracon-schedule app:build


                Building process


 Build version? [v1.3.0]:
 > ^C^C
➜ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   box.json
@owenvoke
Copy link
Member

I thought this was solved by this code where it should catch the usage of SIGINT and call the clear() method which should restore the original Box configuration. 🤔

The PCNTL extension should be enabled on macOS (if installed through Brew) by default afaik. Unless macOS overwrites the SIGINT flow when using Ctrl+C.

@hylke94
Copy link

hylke94 commented Feb 12, 2023

To confirm, this is still an issue. Just troubleshoot for two hours, to finally find this issue..

@owenvoke
Copy link
Member

@hylke94, to confirm, what OS are you using?

@hylke94
Copy link

hylke94 commented Feb 13, 2023

@hylke94, to confirm, what OS are you using?

Latest Manjaro KDE

@rforced rforced linked a pull request Jul 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix box.json getting emptied on Ctrl-C rforced/laravel-zero-framework
3 participants
@hylke94 @owenvoke @nunomaduro