Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub strategy should respect composer.json PHP requirements #11

Open
mpociot opened this issue Feb 16, 2023 · 0 comments
Open

GitHub strategy should respect composer.json PHP requirements #11

mpociot opened this issue Feb 16, 2023 · 0 comments

Comments

@mpociot
Copy link

mpociot commented Feb 16, 2023

I'm currently running into a little problem with Expose in combination with the phar updater where I'm unsure how to fix this.

The problem is that I need to tag a new version (2.6.0) which will drop PHP 8.0 support
The GitHub strategy updater only checks for a newer version though - regardless of the PHP version constraints.
This means that running expose self-update on version 2.5.0 with PHP 8.0 will see that there's a new version and download it – even though this new version will not work.

As I said, I'm not really sure what's the best way to fix this.

Checking for PHP version constraints in the updater could work, but we would miss intermediate updates. Imagine a user is on version 2.4 and wants to update.
The updater only detects the latest version, which would be 2.6 and not run on PHP 8.0, while a 2.5 release might be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant