Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate the "target an aggregate with its key" feature #994

Closed
gdementen opened this issue Dec 9, 2021 · 1 comment
Closed

deprecate the "target an aggregate with its key" feature #994

gdementen opened this issue Dec 9, 2021 · 1 comment
Assignees
@gdementen
Labels
cleanup difficulty: low enhancement priority: high
Milestone
0.34

Comments

@gdementen
Copy link
Contributor

Reference: #983 (comment)

Since I am unsure whether it is used by users, we need to deprecate it first.

Priority high, so that we can remove it and all the cruft that goes with it.
@gdementen gdementen added this to the 0.34 milestone Dec 9, 2021
@gdementen gdementen self-assigned this Dec 9, 2021
@gdementen
Copy link
Contributor Author

also, it is even harmful in some cases (in the demo model there are a few occurrences where users need to use:

group >> None to work around this unwanted feature

gdementen added a commit to gdementen/larray that referenced this issue Feb 14, 2023
@gdementen
FEAT: deprecate target aggregated label via the group that created it (…
706f0c7 
…closes larray-project#994)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdementen gdementen

Labels
cleanup difficulty: low enhancement priority: high
Projects
None yet
Milestone
0.34
Development

No branches or pull requests
1 participant
@gdementen