Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use color table file format for labels.csv #53

Open
lassoan opened this issue Apr 25, 2024 · 1 comment
Open

Use color table file format for labels.csv #53

lassoan opened this issue Apr 25, 2024 · 1 comment

Comments

@lassoan
Copy link
Owner

lassoan commented Apr 25, 2024

Labels.csv file could be simplified by using shorter column names (those proposed in Slicer/Slicer#7593).
Also, we could add the segment colors there as well, which would allow us to automatically generate segmentation terminology .term.json file from labels.csv.

@diazandr3s what do you think about updating all our labels.csv files in the current models?

  • LabelValue - no change
  • Name - no change
  • Color.R - new field, set from the colors currently in term.json files, value is 0-255
  • Color.G - new field
  • Color.B - new field
  • Color.A - new field
  • SegmentedPropertyCategoryCodeSequence.CodingSchemeDesignator -> Category.CodingSchemeDesignator
  • SegmentedPropertyCategoryCodeSequence.CodeValue -> Category.CodeValue
  • SegmentedPropertyCategoryCodeSequence.CodeMeaning -> Category.CodeMeaning
  • SegmentedPropertyTypeCodeSequence.CodingSchemeDesignator -> Type.CodingSchemeDesignator
  • SegmentedPropertyTypeCodeSequence.CodeValue -> Type.CodeValue
  • SegmentedPropertyTypeCodeSequence.CodeMeaning -> Type.CodeMeaning
  • SegmentedPropertyTypeModifierCodeSequence.CodingSchemeDesignator -> TypeModifier.CodingSchemeDesignator
  • SegmentedPropertyTypeModifierCodeSequence.CodeValue -> TypeModifier.CodeValue
  • SegmentedPropertyTypeModifierCodeSequence.CodeMeaning -> TypeModifier.CodeMeaning
  • AnatomicRegionSequence.CodingSchemeDesignator -> AnatomicRegion.CodingSchemeDesignator
  • AnatomicRegionSequence.CodeValue -> AnatomicRegion.CodeValue
  • AnatomicRegionSequence.CodeMeaning -> AnatomicRegion.CodeMeaning
  • AnatomicRegionModifierSequence.CodingSchemeDesignator -> AnatomicRegionModifier.CodingSchemeDesignator
  • AnatomicRegionModifierSequence.CodeValue -> AnatomicRegionModifier.CodeValue
  • AnatomicRegionModifierSequence.CodeMeaning -> AnatomicRegionModifier.CodeMeaning

I could do download all the zip files from the model github release, update the labels.json files, and upload the new zip files; and update the code to use the new format. Older version of the extension would not work with the new models, but users then can just update to the latest extension version (and it is still better to do this breaking change sooner than later).

@diazandr3s
Copy link
Collaborator

Hi @lassoan,

This is a good idea! Let's make this change.
Please let me know how I can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants