Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model-specific workarounds from auto3dseg_segresnet_inference.py #69

Open
lassoan opened this issue May 21, 2024 · 0 comments
Open
Assignees

Comments

@lassoan
Copy link
Owner

lassoan commented May 21, 2024

To ensure long-term sustainability (keep complexity in check) we need to keep auto3dseg_segresnet_inference.py inference script model-independent.

Instead of if 'whole-head' in model_file, we should have an option called something like KeepLargestConnectedComponent in the model. It should be also nicely documented (it could be just 1-2 sentences as comments at the top of auto3dseg_segresnet_inference.py file) to make it clear for model developers that they are allowed to use it.

I did not emphasize this with BRATS, as I thought that it was an exception - that nobody should follow that example, so no need to generalize. But at least we should document it in auto3dseg_segresnet_inference.py file. If we think that this kind of multichannel input is acceptable (not just a bad workaround) then we should add an option that describes the concept (MultiChannelInput?) and use that option name instead of referring to a specific model name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants