-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate not only compilerArguments but also compilerArgs #11
Comments
@kwin sorry I'm only seeing & reacting to this now! Would you be willing to raise a PR for this? |
@kwin if you would be interested in raising a PR for this, that would certainly still be interesting! |
If you use a recent Maven version like 3.9.1 it will also start logging warnings if you use deprecated plug-in options:
|
@wborn if you would be interested in raising a PR for this, I'm happy to click Merge on it. |
compilerArguments
was deprecated. Now you should rather usecompilerArgs
to configure eg. the properties file. The tricky thing is that the latter gets a List of Strings. There are multiple ways to configure that within a pom.xml. Also, it should not only consider global plugin configuration settings but also execution specific configurations. The code at https://github.com/lastnpe/eclipse-external-annotations-m2e-plugin/blob/master/eclipse-external-annotations-m2e-plugin.core/src/org/lastnpe/m2e/core/configurator/ClasspathConfigurator.java#L333 needs to be adjusted.The text was updated successfully, but these errors were encountered: