Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operation to replace missing values #195

Open
dlindhol opened this issue Feb 18, 2021 · 2 comments
Open

Add operation to replace missing values #195

dlindhol opened this issue Feb 18, 2021 · 2 comments
Milestone

Comments

@dlindhol
Copy link
Member

This relies on missingValue metadata. If there are no missing values defined in the metadata treat this as a no-op.

@dlindhol dlindhol added this to the 0.1.0 milestone Feb 18, 2021
@dlindhol
Copy link
Member Author

There can also be a fillValue in the metadata (#146). The ReplaceMissing operation should replace values that match either missingValue or fillValue. The metadata should be updated with missingValue set to the new value and fillValue should be removed.

Note that "NaN" and "null" require special logic beyond simple equality.

Note that a dataset with NullData should have missingValue="null" in the metadata. A fillValue in the metadata must not be "null".

@dlindhol
Copy link
Member Author

ReplaceMissing needs to be targeted to a specific variable since the data types may be incompatible.
Consider ReplaceAllMissing to try to replace for all variables. This is a common scenario (as implemented in latis2's ReplaceMissingOperation) where all variable with missing values are doubles.

Note that latis3 needs to be able to validate the applicability of an operation based on metadata and model alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant