Skip to content

Commit 28f702d

Browse files
authored
ci: fixing java-server-sdk workflow syntax (#20)
1 parent 2eb7364 commit 28f702d

File tree

4 files changed

+28
-19
lines changed

4 files changed

+28
-19
lines changed

Diff for: .github/workflows/java-server-sdk.yml

+1-8
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
test-platforms-and-versions:
1515
strategy:
1616
matrix:
17-
os: [windows-2019, ubuntu-20.04]
17+
os: [ubuntu-20.04]
1818
javaversion: [8, 11, 17, 19]
1919
runs-on: ${{ matrix.os }}
2020
steps:
@@ -26,13 +26,6 @@ jobs:
2626
workspace_path: 'lib/sdk/server'
2727
java_version: ${{ matrix.javaversion }}
2828

29-
- name: Contract Tests
30-
- uses: ./.github/actions/contract-tests
31-
with:
32-
service_project_file: pkgs/sdk/server/contract-tests/TestService.csproj
33-
service_dll_file: pkgs/sdk/server/contract-tests/bin/debug/net6.0/ContractTestService.dll
34-
token: ${{ secrets.GITHUB_TOKEN }}
35-
3629
test-contract-tests:
3730
runs-on: ubuntu-latest
3831
steps:

Diff for: .github/workflows/release-please.yml

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
outputs:
1313
package-server-sdk-otel-released: ${{ steps.release.outputs['lib/java-server-sdk-otel--release_created'] }}
1414
package-sdk-common-released: ${{ steps.release.outputs['lib/java-sdk-common--release_created'] }}
15+
package-sdk-internal-released: ${{ steps.release.outputs['lib/java-sdk-internal--release_created'] }}
16+
package-server-sdk-released: ${{ steps.release.outputs['lib/java-server-sdk--release_created'] }}
1517

1618
steps:
1719
- uses: google-github-actions/release-please-action@v4

Diff for: README.md

+13
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ This includes shared libraries, used by SDKs and other tools, as well as SDKs.
55

66
## Packages
77

8+
| SDK Packages | API Docs | maven | issues | tests |
9+
| ------------------------------------------------------------------ |---------------------------------------------------------------------| ------------------------------------------------------------- | ------------------------------------- | ----------------------------------------------------------------- |
10+
| [@launchdarkly/java-server-sdk](lib/sdk/server/README.md) | [![Documentation][server-sdk-docs-badge]][server-sdk-docs-link] | [![maven][server-sdk-maven-badge]][server-sdk-maven-link] | [Issues][server-sdk-issues] | [![Actions Status][server-sdk-ci-badge]][server-sdk-ci-link] |
11+
812
| Shared Packages | API Docs | maven | issues | tests |
913
| ------------------------------------------------------------------ |---------------------------------------------------------------------| ------------------------------------------------------------- | ------------------------------------- | ----------------------------------------------------------------- |
1014
| [@launchdarkly/java-sdk-internal](lib/shared/internal/README.md) | [![Documentation][sdk-internal-docs-badge]][sdk-internal-docs-link] | [![maven][sdk-internal-maven-badge]][sdk-internal-maven-link] | [Issues][sdk-internal-issues] | [![Actions Status][sdk-internal-ci-badge]][sdk-internal-ci-link] |
@@ -49,6 +53,15 @@ We encourage pull requests and other contributions from the community. Check out
4953
- [apidocs.launchdarkly.com](https://apidocs.launchdarkly.com/ 'LaunchDarkly API Documentation') for our API documentation
5054
- [blog.launchdarkly.com](https://blog.launchdarkly.com/ 'LaunchDarkly Blog Documentation') for the latest product updates
5155

56+
[//]: # 'java-server-sdk'
57+
[server-sdk-issues]: https://github.com/launchdarkly/java-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22package%3A+java-server-sdk%22+
58+
[server-sdk-maven-badge]: https://img.shields.io/maven-central/v/com.launchdarkly/launchdarkly-java-server-sdk
59+
[server-sdk-maven-link]: https://central.sonatype.com/artifact/com.launchdarkly/launchdarkly-java-server-sdk
60+
[server-sdk-ci-badge]: https://github.com/launchdarkly/java-core/actions/workflows/java-server-sdk.yml/badge.svg
61+
[server-sdk-ci-link]: https://github.com/launchdarkly/java-core/actions/workflows/java-server-sdk.yml
62+
[server-sdk-docs-badge]: https://img.shields.io/static/v1?label=GitHub+Pages&message=API+reference&color=00add8
63+
[server-sdk-docs-link]: https://launchdarkly.github.io/java-core/lib/sdk/server/
64+
5265
[//]: # 'java-server-sdk-otel'
5366
[server-otel-issues]: https://github.com/launchdarkly/java-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22package%3A+java-server-sdk-otel%22+
5467
[server-otel-maven-badge]: https://img.shields.io/maven-central/v/com.launchdarkly/launchdarkly-java-server-sdk-otel

Diff for: lib/sdk/server/build.gradle

+12-11
Original file line numberDiff line numberDiff line change
@@ -277,17 +277,18 @@ javadoc {
277277
}
278278

279279
// Force the Javadoc build to fail if there are any Javadoc warnings. See: https://discuss.gradle.org/t/javadoc-fail-on-warning/18141/3
280-
if (JavaVersion.current().isJava8Compatible()) {
281-
tasks.withType(Javadoc) {
282-
// The '-quiet' as second argument is actually a hack,
283-
// since the one paramater addStringOption doesn't seem to
284-
// work, we extra add '-quiet', which is added anyway by
285-
// gradle. See https://github.com/gradle/gradle/issues/2354
286-
// See JDK-8200363 (https://bugs.openjdk.java.net/browse/JDK-8200363)
287-
// for information about the -Xwerror option.
288-
options.addStringOption('Xwerror', '-quiet')
289-
}
290-
}
280+
// TODO: SC-245226 fix associated warnings and uncomment
281+
// if (JavaVersion.current().isJava8Compatible()) {
282+
// tasks.withType(Javadoc) {
283+
// // The '-quiet' as second argument is actually a hack,
284+
// // since the one paramater addStringOption doesn't seem to
285+
// // work, we extra add '-quiet', which is added anyway by
286+
// // gradle. See https://github.com/gradle/gradle/issues/2354
287+
// // See JDK-8200363 (https://bugs.openjdk.java.net/browse/JDK-8200363)
288+
// // for information about the -Xwerror option.
289+
// options.addStringOption('Xwerror', '-quiet')
290+
// }
291+
// }
291292

292293
// Returns the names of all Java packages defined in this library - not including
293294
// enclosing packages like "com" that don't have any classes in them.

0 commit comments

Comments
 (0)