Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing and opening settings dismisses "exporting" and "importing" screens #9879

Open
personalizedrefrigerator opened this issue Feb 8, 2024 · 0 comments · May be fixed by #10520
Open

Closing and opening settings dismisses "exporting" and "importing" screens #9879

personalizedrefrigerator opened this issue Feb 8, 2024 · 0 comments · May be fixed by #10520
Labels
backlog We'll get to it... eventually... bug It's a bug desktop All desktop platforms

Comments

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Feb 8, 2024 •
edited
Loading

Operating system

Linux

Joplin version

2.14.12

Desktop version info

Joplin 2.14.12 (dev, linux)

Client ID: 50a95f7d97414363a84473b388d1916d
Sync Version: 3
Profile Version: 45
Keychain Supported: No

Revision: 01ec640

CodeMirror 6 snippets: 0.0.4
Simple Backup: 1.3.5

Current behaviour

  1. Start a long import or export (for example, by importing a directory with many thousands of files)
  2. Open settings (tools > options)
  3. Close settings
  4. Observe that the "Importing" or "exporting" screen is no longer visible

Expected behaviour

Either:

  1. There should be a way to dismiss the "Importing"/"Exporting" screens without going to settings (e.g. an "×" button) to indicate that this is intended behavior, or
    • Edit: This would also likely require adding logic to indicate that an export/import is running in the background even if the screen is dismissed. Such a UI change would likely need to be discussed on the forum.
  2. The "Importing" or "Exporting" screen should remain visible while an import or export is in progress.

Logs

No response
@personalizedrefrigerator personalizedrefrigerator added bug It's a bug desktop All desktop platforms backlog We'll get to it... eventually... labels Feb 8, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title "Exporting" and "importing" screens are hidden by opening and closing settings Closing and opening settings dismisses "exporting" and "importing" screens Feb 8, 2024
henriqueeapsilva added a commit to henriqueeapsilva/joplin that referenced this issue Apr 3, 2024
@henriqueeapsilva
Fix laurent22#9879: unexpected behavior between importing/exporting s…
e97cf31 
…creens and opening settings.

This issue implies that during the process of Importing and Exporting, opening and closing the settings screen closes the previous display that appears during those actions.
That happens because the importing screen is a Modal, which means it appears over the main screen, making the setting screen go to the main screen when the back button is pressed and not the previously appearing modal. For that, I choose the following solution:
- a close button is added to show that the import and export processes are processes that happen on the back, and the users can continue using the app. This is an expected behavior that is intuitive and saves time for the user, increasing user experience.
I fixed this issue by adding a button that goes with the style of the app:
- adding a button with a clicked-based function to close the modal on showModalMessage.tsx;
- styling on main.scss based on the previous implementation.

Signed-off-by: Henrique Silva <[email protected]>
Closed
@fabiogvdneto fabiogvdneto linked a pull request May 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog We'll get to it... eventually... bug It's a bug desktop All desktop platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Desktop: Show notification on import/export using interop service fabiogvdneto/joplin
1 participant
@personalizedrefrigerator