You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An AutoUpdater Service that identifies the latest updates from GitHub Releases. For Windows, it can update it with no problems after flags are enabled and a parameter is switched to true in code.
Expected behavior
For MacOS, we have an issue. We need to generate the file latest-mac.yml for architecture "arm64". For now, this file is overwritten by the file for Intel architecture. We need both files. Possible solutions:
switching to universal architecture so that Electron's autoUpdater knows automatically to update regarding the architecture. -> as discussed, this is much more complicated and it needs thorough testing. Not possible for now.
using afterAllArtifactBuild hook, rename the file latest-mac.yml to latest-mac-arm64.yml. This way, the file can't be overwritten. -> latest-mac.yml is not generated in the hook, so there is nothing we can do to rename it.
using afterAllArtifactBuild hook, create from code latest-mac-arm64.yml file -> unfortunately while this works, it interferes with signing the app.
after the app is published, inside renameAllAssets script, take the files from GitHub Releases (app is already signed) and then create latest-mac-arm64.yml file and publish it -> to be done
the problem regarding latest-mac-arm64.yml file should be solved
a PR where I officially trigger the updates by switching enableAutodownloads to true and making sure that the update flow respects Visual Studio Code update's flow. This PR also includes modifying the download update button when the flag for auto updates is set to true to follow the logic of auto updates instead of manual updates.
testing phase 1: PR is tested on all platforms (I need someone to test on Mac arm64) and possible problems are solved.
a post to announce that auto updates are finished and that the users can start testing it + how can they start this service
a post to document this service
testing phase 2: awaiting feedback from users and solving possible issues.
Logs
No response
The text was updated successfully, but these errors were encountered:
Thanks for creating this Alice. Also there's this issue I mentioned on Discord:
I see that when I click on "Check for update" in the "Help" menu, and then click on "Download", it still go to download the release. Instead that should all be connected to your new updater. Please create this list in a GitHub issue on the main repo
Thanks for creating this Alice. Also there's this issue I mentioned on Discord:
I see that when I click on "Check for update" in the "Help" menu, and then click on "Download", it still go to download the release. Instead that should all be connected to your new updater. Please create this list in a GitHub issue on the main repo
Could you add it to the list please?
Hi! This is included under this bullet point:
a PR where I officially trigger the updates by switching enableAutodownloads to true and making sure that the update flow respects Visual Studio Code update's flow. This PR also includes modifying the download update button when the flag for auto updates is set to true to follow the logic of auto updates instead of manual updates.
Operating system
macOS
Joplin version
3.1.8
Desktop version info
No response
Current behaviour
An AutoUpdater Service that identifies the latest updates from GitHub Releases. For Windows, it can update it with no problems after flags are enabled and a parameter is switched to true in code.
Expected behavior
For MacOS, we have an issue. We need to generate the file latest-mac.yml for architecture "arm64". For now, this file is overwritten by the file for Intel architecture. We need both files. Possible solutions:
afterAllArtifactBuild
hook, rename the file latest-mac.yml to latest-mac-arm64.yml. This way, the file can't be overwritten. -> latest-mac.yml is not generated in the hook, so there is nothing we can do to rename it.afterAllArtifactBuild
hook, create from code latest-mac-arm64.yml file -> unfortunately while this works, it interferes with signing the app.renameAllAssets
script, take the files from GitHub Releases (app is already signed) and then create latest-mac-arm64.yml file and publish it -> to be doneList with what follows:
Logs
No response
The text was updated successfully, but these errors were encountered: