Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for loading YouTube Music albums #11

Open
SpookyO opened this issue Dec 30, 2023 · 4 comments
Open

Add alias for loading YouTube Music albums #11

SpookyO opened this issue Dec 30, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@SpookyO
Copy link

SpookyO commented Dec 30, 2023

Lavaplayer does support loading YouTube Music album/playlist only if its in a correct form.

Currently lavaplayer doesn't support loading this type of youtube music album urls.

Here's an example album url (/browse): https://music.youtube.com/browse/MPREb_d8mqe4d4UR0

Lavaplayer will just raise error upon passing this album url. (which eventually redirects to actual playlist url upon clicking manually)

@topi314 topi314 added the enhancement New feature or request label Dec 30, 2023
@DxsSucuk
Copy link

DxsSucuk commented Jan 5, 2024

Doesn't this already exist inside the code? YouTube Music Albums are not different from YouTube Playlists?
And if so, removing the music. at the domain directs you towards a youtube playlist.

@DxsSucuk
Copy link

DxsSucuk commented Jan 5, 2024

Just tested it with my bot using latest release.
image
image

I am unsure thou, how the url in the Issue description has been found, its valid but redirects to a playlist url.

@SpookyO SpookyO changed the title Add support for loading YouTube Music album Add alias for loading YouTube Music albums Jan 5, 2024
@SpookyO
Copy link
Author

SpookyO commented Jan 5, 2024

Just tested it with my bot using latest release.

I am unsure thou, how the url in the Issue description has been found, its valid but redirects to a playlist url.

Hey, pardon, I just updated the issue. Its true lavaplayer can load /playlists/... format albums but it cannot load /browse/... format albums. Why does it matter if you say, some youtube music searcher returns /browse/... type of albums rather than /playlists/... which makes it hard to directly pass the url in lavaplayer.

Yes, we can indeed find out the redirected url ourselves. But i think lavaplayer still should support this url alias.

@DxsSucuk
Copy link

DxsSucuk commented Jan 5, 2024

I tried solving this thing sadly couldn't do much. Since there is no active redirect but rather a location change via js. But it seems like if you get past the consent page that loads first you should be able to just check if there is any entry for

https:\/\/music\.youtube\.com\/playlist\?list=([a-zA-Z0-9_-]{11})

Because the playlist id is written into the site.

@devoxin devoxin transferred this issue from lavalink-devs/lavaplayer May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants