Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement onKeyEnter event #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

millerf
Copy link

@millerf millerf commented Sep 15, 2018

fix #30

@lbertenasco
Copy link
Owner

Hi @millerf !
Could you elaborate a bit more why you did this?
I'm not sure what are you trying to solve with this, thanks!

Shouldn't this be an @Output @Input() onKeyEnter = new EventEmitter();?

You'll need to change this function as well for it to work when it's not a textarea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[onEnter] should use (onEnter) binding
2 participants