File tree 1 file changed +6
-3
lines changed
1 file changed +6
-3
lines changed Original file line number Diff line number Diff line change @@ -397,7 +397,7 @@ jobs:
397
397
export GRENEDALF_BUILD_STATIC=""
398
398
# if [[ "${{ matrix.os }}" == "ubuntu-latest" ]] && [[ "${{ matrix.compiler }}" == "gcc" ]]; then
399
399
# if [[ "${{ matrix.os }}" == "ubuntu-latest" ]] ; then
400
- export GRENEDALF_BUILD_STATIC="-DGRENEDALF_BUILD_STATIC=ON"
400
+ # export GRENEDALF_BUILD_STATIC="-DGRENEDALF_BUILD_STATIC=ON"
401
401
# fi
402
402
403
403
cmake -S . -B ./build ${GRENEDALF_BUILD_STATIC}
@@ -437,9 +437,12 @@ jobs:
437
437
# These are the ones that we want to publish with release versions.
438
438
- name : Upload Binaries
439
439
# If the Ubuntu binary here is changed, it needs to be changed above as well,
440
- # to enable static building for that version!
440
+ # to enable static building for that version! --> Update: Not doing static build
441
+ # on Ubuntu any more, because of liblzma, which fails with static linking.
442
+ # We likely do not need static binaries on ubuntu anyway - should be easy enough to compile.
441
443
# if: ( matrix.os == 'ubuntu-latest' && matrix.compiler == 'gcc' ) || matrix.compiler == 'apple'
442
- if : matrix.os == 'ubuntu-latest' || matrix.compiler == 'apple'
444
+ # if: matrix.os == 'ubuntu-latest' || matrix.compiler == 'apple'
445
+ if : matrix.compiler == 'apple'
443
446
uses : actions/upload-artifact@v4
444
447
with :
445
448
name : binary-${{ matrix.os }}-${{ matrix.compiler }}
You can’t perform that action at this time.
0 commit comments