Skip to content

Commit bcff827

Browse files
committed
Deactivate static linking on ubuntu
1 parent 14a8402 commit bcff827

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Diff for: .github/workflows/ci.yaml

+6-3
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ jobs:
397397
export GRENEDALF_BUILD_STATIC=""
398398
# if [[ "${{ matrix.os }}" == "ubuntu-latest" ]] && [[ "${{ matrix.compiler }}" == "gcc" ]]; then
399399
# if [[ "${{ matrix.os }}" == "ubuntu-latest" ]] ; then
400-
export GRENEDALF_BUILD_STATIC="-DGRENEDALF_BUILD_STATIC=ON"
400+
# export GRENEDALF_BUILD_STATIC="-DGRENEDALF_BUILD_STATIC=ON"
401401
# fi
402402
403403
cmake -S . -B ./build ${GRENEDALF_BUILD_STATIC}
@@ -437,9 +437,12 @@ jobs:
437437
# These are the ones that we want to publish with release versions.
438438
- name: Upload Binaries
439439
# If the Ubuntu binary here is changed, it needs to be changed above as well,
440-
# to enable static building for that version!
440+
# to enable static building for that version! --> Update: Not doing static build
441+
# on Ubuntu any more, because of liblzma, which fails with static linking.
442+
# We likely do not need static binaries on ubuntu anyway - should be easy enough to compile.
441443
# if: ( matrix.os == 'ubuntu-latest' && matrix.compiler == 'gcc' ) || matrix.compiler == 'apple'
442-
if: matrix.os == 'ubuntu-latest' || matrix.compiler == 'apple'
444+
# if: matrix.os == 'ubuntu-latest' || matrix.compiler == 'apple'
445+
if: matrix.compiler == 'apple'
443446
uses: actions/upload-artifact@v4
444447
with:
445448
name: binary-${{ matrix.os }}-${{ matrix.compiler }}

0 commit comments

Comments
 (0)