-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide benchmarks on MSVC #84
Comments
I'm fond of the second approach, because it requires the least maintenance and because it looks cool. |
Forget it, too complex to be worth it. |
Sorry, I was out for the weekend. The issue with the second approach is that we won't know whether it's a compiler failure or a problem in the benchmark itself. IOW, we wouldn't be able to "test" that the benchmarks are not broken. |
No worries. Do you think you can setup Appveyor to push benchmark results in a manner similar to Travis? EDIT: For MSVC only |
EDIT: Fixed by 78b35bd (WIP) |
Surprise surprise, MSVC sets Ideas? |
That's because MSVC is not C++11/14 compliant AFAIK. |
So there's nothing to do here; any benchmark that actually require full C++11/14 compliance can't support MSVC. Now, we could go with more granularity and require specific features |
It isn't, but most libraries we actually care about don't need it either. Also see #93. |
As a matter of fact, Metal works from MSVC 14 onwards and Brigand from MSVC 12 onwards, not to mention MPL and Fusion which date back to over a decade ago. I haven't found any special requirements for Meta, so I thought it could be handled by MSVC 14 least, but it appears it cannot. Also surprising is the fact MSVC 12 doesn't appear to handle |
Ok, so if I'm not mistaken we only need to run and push the benchmarks on MSVC from Appveyor, right? |
Correct, then update |
^ Because GCC 5 is already generated on Travis. |
We will have to deal with broken support for newer standards.
Two approaches strike me as the most obvious:
n=1
) before deciding whether the selected compiler version is able to handle a library.The text was updated successfully, but these errors were encountered: