-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip compiler versions not supported by specific libraries #92
Conversation
@@ -14,14 +14,17 @@ build: | |||
|
|||
environment: | |||
matrix: | |||
- CMAKE_GENERATOR: "Ninja" | |||
- CMAKE_GENERATOR: "MinGW Makefiles" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not testing with MinGW Makefiles anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not because I didn't want to, I simply couldn't get it to work. If MinGW is in the path, then Ninja gets messed up in the head and tries linking MinGW libraries to objects compiled by MSVC. If I try to conditionaly remove it from PATH
, then cmd
gets high on acid and starts complaining about some "google cloud" thingy - somehow setting PATH within an if
statement doesn't work on appveyor, I tried quoting the hell out of it, but to no avail.
Since MinGW is essentially GCC on windows, I felt there was no added value in testing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think this is the first time we are actually testing MSVC, because Ninja would always pick MinGW and I never noticed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then I'm totally OK with dropping MinGW.
I'll update this PR to get rid of |
this allow us to benchmark g++ 5
This PR allows benchmarking GCC 5 (#84)
Note: This is based on #90