Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip compiler versions not supported by specific libraries #92

Merged
merged 3 commits into from
Apr 5, 2016
Merged

Skip compiler versions not supported by specific libraries #92

merged 3 commits into from
Apr 5, 2016

Conversation

brunocodutra
Copy link
Collaborator

This PR allows benchmarking GCC 5 (#84)

Note: This is based on #90

@@ -14,14 +14,17 @@ build:

environment:
matrix:
- CMAKE_GENERATOR: "Ninja"
- CMAKE_GENERATOR: "MinGW Makefiles"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not testing with MinGW Makefiles anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not because I didn't want to, I simply couldn't get it to work. If MinGW is in the path, then Ninja gets messed up in the head and tries linking MinGW libraries to objects compiled by MSVC. If I try to conditionaly remove it from PATH, then cmd gets high on acid and starts complaining about some "google cloud" thingy - somehow setting PATH within an if statement doesn't work on appveyor, I tried quoting the hell out of it, but to no avail.

Since MinGW is essentially GCC on windows, I felt there was no added value in testing it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think this is the first time we are actually testing MSVC, because Ninja would always pick MinGW and I never noticed it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I'm totally OK with dropping MinGW.

@brunocodutra
Copy link
Collaborator Author

I'll update this PR to get rid of FindCXXStandard in the lines of #94.

@ldionne ldionne merged commit 5dbacf6 into ldionne:master Apr 5, 2016
@brunocodutra brunocodutra deleted the gcc_5 branch April 5, 2016 01:04
ldionne pushed a commit that referenced this pull request Apr 5, 2016
once they become available (#92)

closes #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants