Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with custom maps from the Supplementaries mod #1

Open
generikb opened this issue Oct 11, 2023 · 6 comments
Open

Compatibility with custom maps from the Supplementaries mod #1

generikb opened this issue Oct 11, 2023 · 6 comments

Comments

@generikb
Copy link

Supplementaries adds custom explorer maps, so you can send folks to places like villages and custom structures. According to MehVahdJukaar, they're just normal maps (nothing funky he's doing to them) but the distance doesn't show up on them.

Vanilla Explorer Map:
image

Supplementaries Explorer Map:
image

would it be possible to add Supplementaries map compatibility to your mod? Thank you very much!

@Thodor12
Copy link

1.20.2 added these explorer maps as well, which would make those maps from Supplementaries obsolete.
So I wonder how useful it would be to backport this.

@generikb
Copy link
Author

generikb commented Oct 16, 2023

Still been working on this a bit, and it seems like even "chest loot" maps don't show the distance?

So for example, I have this test loot table:

{ "type": "minecraft:chest", "pools": [ { "rolls": 1, "entries": [ { "type": "minecraft:item", "name": "minecraft:map", "functions": [ { "function": "minecraft:exploration_map", "destination": "minecraft:igloo", "decoration": "target_x", "zoom": 2, "skip_existing_chunks": true } ] } ] } ] }

and here's what I get:

image
image

it doesn't seem to be classifying itself as an "Explorer's Map", maybe I'm doing something wrong?

@Raycoms
Copy link
Contributor

Raycoms commented Oct 16, 2023

Can you try the newest I uploaded?

@generikb
Copy link
Author

image

Look at you, ya big brain'd beautiful human you!

@MehVahdJukaar
Copy link

MehVahdJukaar commented Oct 23, 2023

so if you want yo make it compatible just also add a check for "CustomDecorations" in nbt. rest works like vanilla

@generikb
Copy link
Author

YASSSS that would be very very awesome to have compatible! Thank you in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants