fix weid bug on columns_up_and_down

Author: TomWambsgans

crates/air/src/utils.rs

@@ -1,5 +1,6 @@
 use multilinear_toolkit::prelude::*;
 use p3_field::Field;
+use tracing::instrument;
 
 pub(crate) fn matrix_up_lde<F: Field>(point: &[F]) -> F {
     /*
@@ -129,11 +130,17 @@ fn next_mle<F: Field>(point: &[F]) -> F {
         .sum()
 }
 
+#[instrument(skip_all, fields(len = columns.len(), col_len = columns[0].len()))]
 pub(crate) fn columns_up_and_down<F: Field>(columns: &[&[F]]) -> Vec<Vec<F>> {
-    columns
-        .par_iter()
-        .map(|c| column_up(c))
-        .chain(columns.par_iter().map(|c| column_down(c)))
+    (0..columns.len() * 2)
+        .into_par_iter()
+        .map(|i| {
+            if i < columns.len() {
+                column_up(columns[i])
+            } else {
+                column_down(columns[i - columns.len()])
+            }
+        })
         .collect()
 }
 

crates/rec_aggregation/src/recursion.rs

@@ -180,7 +180,7 @@ fn run_recursion_benchmark() -> RecursionBenchStats {
     // #[rustfmt::skip] // debug
     // std::fs::write("public_input.txt", build_public_memory(&public_input).chunks_exact(8).enumerate().map(|(i, chunk)| { format!("{} - {}: {}\n", i, i * 8, chunk.iter().map(|x| x.to_string()).collect::<Vec<_>>().join(", ")) }).collect::<String>(),).unwrap();
 
-    // utils::init_tracing();
+    utils::init_tracing();
     let (bytecode, function_locations) = compile_program(&program_str);
     let time = Instant::now();
     let (proof_data, proof_size) = prove_execution(

crates/rec_aggregation/src/xmss_aggregate.rs

@@ -308,7 +308,7 @@ pub fn bench_xmss(n: usize, log_lifetime: usize) -> Duration {
 
 #[test]
 fn test_xmss_aggregate() {
-    //utils::init_tracing();
+    utils::init_tracing();
     use p3_field::Field;
     let n_public_keys: usize = std::env::var("NUM_XMSS_AGGREGATED")
         .unwrap_or("100".to_string())