whirlaway: copy utils crate

Author: tcoratger

Cargo.toml

@@ -11,6 +11,7 @@ members = [
     "crates/leanSnark",
     "crates/leanVm",
     "crates/leanLookup",
+    "crates/utils",
 ]
 resolver = "3"
 
@@ -42,22 +43,34 @@ lean-isa = { path = "crates/leanIsa" }
 lean-snark = { path = "crates/leanSnark" }
 lean-vm = { path = "crates/leanVm" }
 lean-lookup = { path = "crates/leanLookup" }
+utils = { path = "crates/utils" }
 
-p3-field = { git = "https://github.com/Plonky3/Plonky3.git", rev = "5ebf8e4" }
-p3-symmetric = { git = "https://github.com/Plonky3/Plonky3.git", rev = "5ebf8e4" }
-p3-baby-bear = { git = "https://github.com/Plonky3/Plonky3.git", rev = "5ebf8e4" }
-p3-koala-bear = { git = "https://github.com/Plonky3/Plonky3.git", rev = "5ebf8e4" }
-p3-air = { git = "https://github.com/Plonky3/Plonky3.git", rev = "5ebf8e4" }
-p3-matrix = { git = "https://github.com/Plonky3/Plonky3.git", rev = "5ebf8e4" }
-p3-poseidon2 = { git = "https://github.com/Plonky3/Plonky3.git", rev = "5ebf8e4" }
-p3-poseidon2-air = { git = "https://github.com/Plonky3/Plonky3.git", rev = "5ebf8e4" }
-
-whir-p3 = { git = "https://github.com/tcoratger/whir-p3.git", rev = "df2241d" }
-
+rand = "0.9.2"
+sha3 = "0.10.8"
+rayon = "1.5.1"
+serde = { version = "1.0.219", features = ["derive"] }
+derive_more = { version = "2.0.1", features = ["full"] }
+pest = "2.7"
+pest_derive = "2.7"
+tracing = "0.1.26"
 thiserror = "2.0"
 proptest = "1.7"
 num-traits = "0.2"
-rand = "0.9"
-rayon = "1.11"
-pest = "2.8"
-pest_derive = "2.8"
+tracing-subscriber = { version = "0.3.19", features = ["std", "env-filter"] }
+tracing-forest = { version = "0.1.6", features = ["ansi", "smallvec"] }
+p3-koala-bear = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-baby-bear = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-field = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-poseidon2 = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-matrix = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-blake3 = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-symmetric = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-air = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-uni-stark = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-poseidon2-air = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-goldilocks = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-challenger = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+p3-util = { git = "https://github.com/TomWambsgans/Plonky3.git", branch = "w" }
+
+whir-p3 = { git = "https://github.com/TomWambsgans/whir-p3", branch = "w" }
+hashsig = { git = "https://github.com/TomWambsgans/hash-sig", branch = "w" }

crates/leanVm/src/air/dot_product.rs

@@ -35,6 +35,14 @@ impl<F> BaseAir<F> for DotProductAir {
     fn width(&self) -> usize {
         DOT_PRODUCT_AIR_COLUMNS
     }
+
+    fn structured(&self) -> bool {
+        true
+    }
+
+    fn degree(&self) -> usize {
+        3
+    }
 }
 
 impl<AB: AirBuilder> Air<AB> for DotProductAir {

crates/leanVm/src/air/vm.rs

@@ -21,6 +21,13 @@ impl<F> BaseAir<F> for VMAir {
     fn width(&self) -> usize {
         N_EXEC_AIR_COLUMNS
     }
+
+    fn structured(&self) -> bool {
+        true
+    }
+    fn degree(&self) -> usize {
+        5
+    }
 }
 
 impl<AB: AirBuilder> Air<AB> for VMAir {

crates/leanVm/src/bytecode/instruction/multilinear_eval.rs

@@ -1,5 +1,5 @@
 use p3_field::BasedVectorSpace;
-use whir_p3::poly::{coeffs::CoefficientList, multilinear::MultilinearPoint};
+use whir_p3::poly::{evals::EvaluationsList, multilinear::MultilinearPoint};
 
 use crate::{
     bytecode::operand::{MemOrConstant, MemOrFp},
@@ -65,7 +65,7 @@ impl MultilinearEvalInstruction {
             .get_vectorized_slice_extension(ptr_point, self.n_vars)?;
 
         // Evaluate the multilinear polynomial.
-        let eval = CoefficientList::new(slice_coeffs).evaluate(&MultilinearPoint(point));
+        let eval = slice_coeffs.evaluate(&MultilinearPoint(point));
 
         // Write the resulting vector back to memory.
         memory_manager.load_data::<F>(ptr_res, eval.as_basis_coefficients_slice())?;

crates/utils/Cargo.toml

@@ -0,0 +1,25 @@
+[package]
+name = "utils"
+version.workspace = true
+edition.workspace = true
+rust-version.workspace = true
+license.workspace = true
+
+[lints]
+workspace = true
+
+[dependencies]
+p3-field.workspace = true
+rayon.workspace = true
+p3-air.workspace = true
+p3-matrix.workspace = true
+p3-challenger.workspace = true
+whir-p3.workspace = true
+tracing.workspace = true
+p3-symmetric.workspace = true
+p3-koala-bear.workspace = true
+rand.workspace = true
+tracing-forest.workspace = true
+p3-poseidon2.workspace = true
+p3-poseidon2-air.workspace = true
+tracing-subscriber.workspace = true

crates/utils/src/constraints_checker.rs

@@ -0,0 +1,63 @@
+use std::marker::PhantomData;
+
+use p3_air::AirBuilder;
+use p3_field::ExtensionField;
+use p3_matrix::dense::RowMajorMatrixView;
+
+use crate::PF;
+
+/*
+Debug purpose
+*/
+
+#[derive(Debug)]
+pub struct ConstraintChecker<'a, IF, EF> {
+    pub main: RowMajorMatrixView<'a, IF>,
+    pub constraint_index: usize,
+    pub errors: Vec<usize>,
+    pub field: PhantomData<EF>,
+}
+
+impl<'a, EF: ExtensionField<PF<EF>> + ExtensionField<IF>, IF: ExtensionField<PF<EF>>> AirBuilder
+    for ConstraintChecker<'a, IF, EF>
+{
+    type F = PF<EF>;
+    type I = PF<EF>;
+    type Expr = IF;
+    type Var = IF;
+    type M = RowMajorMatrixView<'a, IF>;
+
+    #[inline]
+    fn main(&self) -> Self::M {
+        self.main
+    }
+
+    #[inline]
+    fn is_first_row(&self) -> Self::Expr {
+        unreachable!()
+    }
+
+    #[inline]
+    fn is_last_row(&self) -> Self::Expr {
+        unreachable!()
+    }
+
+    #[inline]
+    fn is_transition_window(&self, _: usize) -> Self::Expr {
+        unreachable!()
+    }
+
+    #[inline]
+    fn assert_zero<I: Into<Self::Expr>>(&mut self, x: I) {
+        let x: IF = x.into();
+        if !x.is_zero() {
+            self.errors.push(self.constraint_index);
+        }
+        self.constraint_index += 1;
+    }
+
+    #[inline]
+    fn assert_zeros<const N: usize, I: Into<Self::Expr>>(&mut self, _: [I; N]) {
+        unreachable!()
+    }
+}

crates/utils/src/constraints_folder.rs

@@ -0,0 +1,62 @@
+use p3_air::AirBuilder;
+use p3_field::{ExtensionField, Field};
+use p3_matrix::dense::RowMajorMatrixView;
+
+use crate::PF;
+
+#[derive(Debug)]
+pub struct ConstraintFolder<'a, NF, EF>
+where
+    NF: ExtensionField<PF<EF>>,
+    EF: ExtensionField<NF>,
+{
+    pub main: RowMajorMatrixView<'a, NF>,
+    pub alpha_powers: &'a [EF],
+    pub accumulator: EF,
+    pub constraint_index: usize,
+}
+
+impl<'a, NF, EF> AirBuilder for ConstraintFolder<'a, NF, EF>
+where
+    NF: ExtensionField<PF<EF>>,
+    EF: Field + ExtensionField<NF>,
+{
+    type F = PF<EF>;
+    type I = Self::F;
+    type Expr = NF;
+    type Var = NF;
+    type M = RowMajorMatrixView<'a, NF>;
+
+    #[inline]
+    fn main(&self) -> Self::M {
+        self.main
+    }
+
+    #[inline]
+    fn is_first_row(&self) -> Self::Expr {
+        unreachable!()
+    }
+
+    #[inline]
+    fn is_last_row(&self) -> Self::Expr {
+        unreachable!()
+    }
+
+    #[inline]
+    fn is_transition_window(&self, _: usize) -> Self::Expr {
+        unreachable!()
+    }
+
+    #[inline]
+    fn assert_zero<I: Into<Self::Expr>>(&mut self, x: I) {
+        let x: NF = x.into();
+        let alpha_power = self.alpha_powers[self.constraint_index];
+        self.accumulator += alpha_power * x;
+        self.constraint_index += 1;
+    }
+
+    #[inline]
+    fn assert_zeros<const N: usize, I: Into<Self::Expr>>(&mut self, _: [I; N]) {
+        unreachable!()
+    }
+}

crates/utils/src/display.rs

@@ -0,0 +1,15 @@
+pub fn pretty_integer(i: usize) -> String {
+    // ex: 123456789 -> "123,456,789"
+    let s = i.to_string();
+    let chars: Vec<char> = s.chars().collect();
+    let mut result = String::new();
+
+    for (index, ch) in chars.iter().enumerate() {
+        if index > 0 && (chars.len() - index) % 3 == 0 {
+            result.push(',');
+        }
+        result.push(*ch);
+    }
+
+    result
+}

crates/utils/src/lib.rs

@@ -0,0 +1,34 @@
+#![cfg_attr(not(test), warn(unused_crate_dependencies))]
+
+mod misc;
+pub use misc::*;
+
+mod constraints_folder;
+pub use constraints_folder::*;
+
+mod univariate;
+pub use univariate::*;
+
+mod multilinear;
+pub use multilinear::*;
+
+mod packed_constraints_folder;
+pub use packed_constraints_folder::*;
+
+mod wrappers;
+pub use wrappers::*;
+
+mod display;
+pub use display::*;
+
+mod point;
+pub use point::*;
+
+mod logs;
+pub use logs::*;
+
+mod constraints_checker;
+pub use constraints_checker::*;
+
+mod poseidon2;
+pub use poseidon2::*;

crates/utils/src/logs.rs

@@ -0,0 +1,13 @@
+use tracing_forest::{ForestLayer, util::LevelFilter};
+use tracing_subscriber::{EnvFilter, Registry, layer::SubscriberExt, util::SubscriberInitExt};
+
+pub fn init_tracing() {
+    let env_filter = EnvFilter::builder()
+        .with_default_directive(LevelFilter::INFO.into())
+        .from_env_lossy();
+
+    Registry::default()
+        .with(env_filter)
+        .with(ForestLayer::default())
+        .init();
+}