Skip to content

Commit e29c459

Browse files
tcoratgerclaude
andauthored
docs(fork-choice): clarify equal-slot tie resolution wording (#1143)
The latest-vote extraction docstring said the first vote seen wins on equal slots, while an adjacent comment noted that all proofs under one attestation data share a slot. Read together these could seem to contradict each other. Reword the docstring to state that equal-slot collisions arise only across distinct attestation data, so the first-inserted-wins rule applies at the distinct-data level, consistent with the loop comment. Docs-only change. just check passes. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 3d30769 commit e29c459

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/lean_spec/spec/forks/lstar/fork_choice.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,8 @@ def extract_attestations_from_aggregated_payloads(
628628
Map each participating validator to the latest vote it cast.
629629
630630
This is the LMD view fork choice runs on.
631-
On equal slots the first vote seen wins, since the slot comparison is strict.
631+
Two votes share a slot only across distinct attestation data, never within one data.
632+
On such an equal-slot tie the strict comparison keeps the first distinct data inserted.
632633
633634
A vote whose head sits at or below the finalized slot carries no fork-choice weight.
634635
Such stale votes are skipped here, so callers pass their pool without pre-filtering.

0 commit comments

Comments
 (0)