Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bity.com cashout functionality makes the user wait too long #183

Open
TimDaub opened this issue Jul 5, 2019 · 1 comment
Open

bity.com cashout functionality makes the user wait too long #183

TimDaub opened this issue Jul 5, 2019 · 1 comment

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jul 5, 2019

Scope

  • With merging bity.com crypto off-ramping integration #164 into master, on Exchange.js there us now an option for the user to cash out into their bank account using bity.com
  • To cashout using bity.com, the burner-wallet does the following: (1) Estimates the ETH/$ rate, (2) creates a bity.com order, (3) sends some ETH to a designated bity.com ETH address
  • That process can take a lot of time
  • Right now, the user is presented with the <Loader /> component throughout all this process
  • While it is very likely for the user to be confused about the long waiting time, ironically it's really important that the process is not canceled by the user throughout. This means, the user needs to sit through the "cashout" loading screen without doing anything
  • This yields a very high likely hood of the process not completing in many cases
  • Other Exchange.js functionality pretends to run asynchronously (it doesn't), and gives the user regular feedback of what's happening (e.g. DAI => PDAI)

Deliverables

  • Write a serviceworker script for the bity.com cashout functionality.
  • Store all ephemeral values into localStorage to be able to pick up the cashout task at any time again
  • Notify the user through a loading bar in e.g. Exchange.js about the progress of the order
  • Consider that Exchange.js will likely go away in the future, so maybe a progress in history would make more sense?
  • The user should be able to start a cashout process now, exit the app, reload it, and the cashout process should at all times be able to resume and successfully finish

Gains for the project

  • User has piece of mind when cashing out

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

@MaxStalker
Copy link
Member

I would also consider testing concurent cashouts. I've had a case using localbitcoins, when I would make several transfers within 5 minute window frame :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants