Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes , sometimes . are used to delimit decimals #211

Open
TimDaub opened this issue Jul 12, 2019 · 2 comments
Open

Sometimes , sometimes . are used to delimit decimals #211

TimDaub opened this issue Jul 12, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jul 12, 2019

Scope

  • On the screenshot below there's two different ways of writing currencies $104.59 (using a period) and 3,45 using a comma.

Screen Shot 2019-07-12 at 17 39 44

- Additionally, often a user has to use specifically either `.` or `,` to enter a value. This might be dependent on the browser language a user set

Deliverables

  • Fix this by doing correct internationalization on inputs and in the UI

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

@TimDaub TimDaub added the bug Something isn't working label Jul 12, 2019
@TimDaub TimDaub added this to the Burner Current Sprint milestone Jul 12, 2019
@MaxStalker
Copy link
Member

In your screenshot currency is set to USD, yet message is saying that you "request to send €3"

@TimDaub
Copy link
Collaborator Author

TimDaub commented Jul 12, 2019

Yes, because the other party requested 3€ and my wallet was set to $.
It's an info message that only pops up if two users have different display currencies. I think they'll understand in that context. Surely it could be improved though.

@TimDaub TimDaub self-assigned this Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants