Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmao #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lmao #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ Let's get a bare minimum karaoke machine working. This is your end goal:

![result](react-karaoke-challenge-milestone-1.gif)

- [ ] Display a list of songs with their artist in the left sidebar.
- [ ] The list of songs will come from `http://localhost:4000`.
- [ ] Clicking the `Play` button, located next to each song, will load the song in the right panel.
- [ ] The right panel will display the song's title and lyrics.
- [ ] The song's lyrics should be passed into the `Lyrics` component. You should not be editing this file.
- [ ] When typing into the input, the list of songs should filter by song name.
- [x] Display a list of songs with their artist in the left sidebar.
- [x] The list of songs will come from `http://localhost:4000`.
- [x] Clicking the `Play` button, located next to each song, will load the song in the right panel.
- [x] The right panel will display the song's title and lyrics.
- [x] The song's lyrics should be passed into the `Lyrics` component. You should not be editing this file.
- [x] When typing into the input, the list of songs should filter by song name.

---

Expand All @@ -92,11 +92,11 @@ Let's get a bare minimum karaoke machine working. This is your end goal:
Being the React master that you are, you noticed some extra data and capabilities in the API: `plays`, `likes`, and `dislikes`. So you decided to add some flair to the karaoke machine ;)

- _Tracking Plays_
- [ ] The song list should display a new column with the number of times a song was played.
- [ ] This data, number of plays, will come from the API. Every time a song is played (clicking `Play`), a `PATCH` should be sent to the database to increment this value for that song.
- [ ] If that song is already playing, you should not `PATCH`.
- [x] The song list should display a new column with the number of times a song was played.
- [x] This data, number of plays, will come from the API. Every time a song is played (clicking `Play`), a `PATCH` should be sent to the database to increment this value for that song.
- [x] If that song is already playing, you should not `PATCH`.
- _Likes & Dislikes_
- [ ] The song list should display two new columns showing the likes/dislikes of a song.
- [x] The song list should display two new columns showing the likes/dislikes of a song.
- [ ] Refactor and add buttons for liking and disliking the currently playing song above the playing song. A pre-styled component has been provided for you to use: `VoteBar`
- [ ] The `VoteBar` should be conditionally rendered. It should not appear when a song is not playing.
- [ ] Clicking like/dislike should send a `PATCH` to the database to increment this value for that song.
Expand Down
Loading