Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing course on the errors page #228

Open
dmitriim opened this issue Oct 24, 2024 · 0 comments
Open

Missing course on the errors page #228

dmitriim opened this issue Oct 24, 2024 · 0 comments
Assignees
@bluetom
Labels
enhancement Version 4.5

Comments

@dmitriim
Copy link

If errored courses have same full names, then one of them will be missed on the error page. This is because of c.fullname being used as the first column in this SQL https://github.com/learnweb/moodle-tool_lifecycle/blob/master/classes/local/table/process_errors_table.php#L59

It should use c.id

Did you remember to make the first column something unique in your call to get_records? Duplicate value 'Test course: XS' found in column 'course'.
line 987 of /lib/dml/pgsql_native_moodle_database.php: call to debugging()
line 2017 of /lib/tablelib.php: call to pgsql_native_moodle_database->get_records_sql()
line 2039 of /lib/tablelib.php: call to table_sql->query_db()
line 68 of /admin/tool/lifecycle/errors.php: call to table_sql->out()
@bluetom bluetom self-assigned this Jan 7, 2025
bluetom added a commit that referenced this issue Mar 19, 2025
@bluetom
fix creating backup by changing to mode_general (#233), fix amount in…
af4158b 
…dicator delayed courses, fix missing courses error page (#228)
bluetom added a commit to bluetom/moodle-tool_lifecycle that referenced this issue Mar 24, 2025
@bluetom
Merge Develop 405 (#1)
f908578 
* introduce tabs

* better edit workflow title

* new wf edit header

* change to tab links

* exclude hidden courses of remaining course list if user has not capability viewhiddencourses

* fix settings to work with subplugins correctly

* fix settings problems, subplugin descriptions, version.php of subplugins, counters in the tabs

* change ci to test only against 4.5

* remove additional process class fields for error message table

* fix error writing wf error table

* fix name of uploadfile

* use label of filepicker for testing

* steps and triggers: increase instancename length to 100 and check maxlength in the forms

* step link in wf overview only if courses > 0

* line break in course list of plain text email, nicer course list popup in wf overview

* fix creating backup by changing to mode_general (learnweb#233), fix amount indicator delayed courses, fix missing courses error page (learnweb#228)

* make adminapprove step included, display delayed courses, triggered courses and excluded courses lists in workflowoverview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluetom bluetom

Labels
enhancement Version 4.5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitriim @bluetom