Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token list - view more #5404

Open
314159265359879 opened this issue May 21, 2024 · 3 comments
Open

Token list - view more #5404

314159265359879 opened this issue May 21, 2024 · 3 comments
Assignees
Labels
area:tokens effort:small Expected to take up to 1 day of integration work enhancement enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives

Comments

@314159265359879
Copy link
Contributor

image

Some tokens currently not in the list that is displayed by default, that perhaps should be.
These other exchanges may feel unfairly treated when we show DIKO and ALEX in the default list but not Velar and STSW.
Velar
SP1Y5YSTAHZ88XYK1VPDH24GY0HPX5J4JECTMY4A1.velar-token
Stackswap
SP1Z92MPDQEWZXW36VX71Q25HKF5K2EPCJ304F275.stsw-token-v4a

Mark said:

We may need to start an array in the remote configuration file of Stacks addresses that pertain to tokens that we recognize, to augment the list that ALEX recognizes.
We should add a page to our developer docs that explains our approach and provide [email protected] as a contact point for requesting new additions.
Do you have a sense beyond these two tokens just which others we should include from the start since they're known to us, similar to how we know these ones?

Going through my addresses I found a couple more serious tokens to show in the default list:

Allbridge USDC
SP3Y2ZSH8P7D50B0VBTSX11S7XSG24M1VB9YFQA4K.token-aeusdc
stSTX
SP4SZE494VC2YC5JYG7AYFQ44F5Q4PYV7DVMDPBG.ststx-token
LiSTX
SM26NBC8SFHNW4P1Y4DFH27974P56WN86C92HPEHH.token-lqstx

For the culture?
NOT
SP32AEEF6WW5Y0NMJ1S8SBSZDAY8R5J32NBZFPKKZ.nope

STX-20 tokens are very cheap to distribute, so it is easy to spam the wallet with those. Right now the default is to display them, I think we should consider moving these to the "show more" list as the default.

Eventually, the idea is that users can configure this list as they please to show/hide any token in Leather.

@314159265359879 314159265359879 added enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives enhancement labels May 21, 2024
@314159265359879
Copy link
Contributor Author

These are the new contracts for the tokens ALEX migrated:

ALEX: SP102V8P0F7JX67ARQ77WEA3D3CFB5XW39REDT0AM.token-alex::alex

aBTC: SP2XD7417HGPRTREMKF748VNEQPDRR0RMANB7X1NK.token-abtc::bridged-btc

sUSDT: SP2XD7417HGPRTREMKF748VNEQPDRR0RMANB7X1NK.token-susdt::bridged-usdt

sLUNR: SP2XD7417HGPRTREMKF748VNEQPDRR0RMANB7X1NK.token-slunr::bridged-lunr

sSKO: SP2XD7417HGPRTREMKF748VNEQPDRR0RMANB7X1NK.token-ssko::bridged-sko

When users connect on the platform app.alexlab.co or app.xlink.network, they are currently asked to migrate from the legacy tokens to the new ones. The new tokens are currently hidden by default, and users have to click "show more" to reveal them. Lets add them to the list of tokens that are shown by default too.

@markmhendrickson
Copy link
Collaborator

@kyranjamie would it be simple enough to add an array of addresses to our remote config file for tokens that we recognize in addition to those recognized by the ALEX SDK, which we can check in addition to the SDK when determining whether to show tokens by default?

@kyranjamie
Copy link
Collaborator

kyranjamie commented Jun 18, 2024

Yeah, this would be https://github.com/leather-wallet/extension/labels/effort%3Asmall

A note on API design for implementer: make an array of objects with a property address, rather than just an array of strings. This enables non-breaking API changes when needing to later add additional metadata.

[{ address: 'bc1p...' }, { ... }]

@markmhendrickson markmhendrickson added the effort:small Expected to take up to 1 day of integration work label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tokens effort:small Expected to take up to 1 day of integration work enhancement enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives
Projects
None yet
Development

No branches or pull requests

4 participants