Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: settings design qa #488

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: settings design qa #488

merged 1 commit into from
Sep 30, 2024

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Sep 28, 2024 •
edited
Loading

This PR addresses the following line items from our design QA session (documented in Notion):

  • ItemLayout text wrapping
  • Account Identifier icon is wrong
  • Ensure divider lines run edge to edge
  • Turn off opacity feedback on settings cells, use Pressable
  • Add app version to UI

*Note this one is blocked by work assigned to @edgarkhanzadian:

  • Add waitlist feature for “more options” items (will do after his PR is merged)

*Version number shown here is dev build, in production it will show the current app version:

@fbwoolf fbwoolf self-assigned this Sep 28, 2024
pete-watters
pete-watters approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.38%. Comparing base (2524537) to head (b56ae02).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #488   +/-   ##
=======================================
  Coverage   22.38%   22.38%           
=======================================
  Files         132      132           
  Lines        5521     5521           
  Branches      241      241           
=======================================
  Hits         1236     1236           
  Misses       4285     4285
Components Coverage Δ
bitcoin 53.77% <ø> (ø)
query 12.05% <ø> (ø)
utils 52.45% <ø> (ø)
crypto 69.40% <ø> (ø)
stacks 53.27% <ø> (ø)

@fbwoolf fbwoolf added this pull request to the merge queue Sep 30, 2024
Merged via the queue into dev with commit 812ed74 Sep 30, 2024
13 checks passed
@fbwoolf fbwoolf deleted the fix/settings-design-qa branch September 30, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete-watters pete-watters pete-watters approved these changes

@kyranjamie kyranjamie kyranjamie approved these changes

@edgarkhanzadian edgarkhanzadian Awaiting requested review from edgarkhanzadian

Assignees

@fbwoolf fbwoolf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbwoolf @kyranjamie @pete-watters