Skip to content

Commit da6323e

Browse files
committed
build: remove the AUDIO_SUPPORT and DISPLAY_SUPPORT symbols
Nothing tests either symbol any more. AUDIO_SUPPORT was also selected by PCI_SUPPORT and USB_SUPPORT, which stood for "a sound card could be plugged in here": audio hardware sits behind MMC, SPI, a Bluetooth UART or an SoC PCM block just as often, so the inference never held. The display feature was derived from a literal CONFIG_VGA_CONSOLE or CONFIG_FB in a kernel fragment, which misses every target whose fbdev came from DRM emulation. Delete both symbols, the two selects, the feature translations and the derivation. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
1 parent de2f69b commit da6323e

4 files changed

Lines changed: 0 additions & 13 deletions

File tree

‎config/Config-build.in‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ menu "Global build settings"
103103
you can use this config option to enable it
104104

105105

106-
config DISPLAY_SUPPORT
107-
bool "Show packages that require graphics support (local or remote)"
108-
109106
config BUILD_PATENTED
110107
bool "Compile with support for patented functionality"
111108
help

‎include/target.mk‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -327,9 +327,6 @@ ifeq ($(DUMP),1)
327327
ifneq ($(CONFIG_PCMCIA)$(CONFIG_PCCARD),)
328328
FEATURES += pcmcia
329329
endif
330-
ifneq ($(CONFIG_VGA_CONSOLE)$(CONFIG_FB),)
331-
FEATURES += display
332-
endif
333330
ifneq ($(CONFIG_RTC_CLASS),)
334331
FEATURES += rtc
335332
endif

‎scripts/target-metadata.pl‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@ (@)
1010

1111
while ($_ = shift @_) {
1212
/^arm_v(\w+)$/ and $ret .= "\tselect arm_v$1\n";
13-
/^audio$/ and $ret .= "\tselect AUDIO_SUPPORT\n";
1413
/^boot-part$/ and $ret .= "\tselect USES_BOOT_PART\n";
1514
/^broken$/ and $ret .= "\tdepends on BROKEN\n";
1615
/^cpiogz$/ and $ret .= "\tselect USES_CPIOGZ\n";
17-
/^display$/ and $ret .= "\tselect DISPLAY_SUPPORT\n";
1816
/^dt$/ and $ret .= "\tselect USES_DEVICETREE\n";
1917
/^dt-overlay$/ and $ret .= "\tselect HAS_DT_OVERLAY_SUPPORT\n";
2018
/^emmc$/ and $ret .= "\tselect EMMC_SUPPORT\n";

‎target/Config.in‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,10 @@ config HAS_FPU
1616
config HAS_DT_OVERLAY_SUPPORT
1717
bool
1818

19-
config AUDIO_SUPPORT
20-
bool
21-
2219
config GPIO_SUPPORT
2320
bool
2421

2522
config PCI_SUPPORT
26-
select AUDIO_SUPPORT
2723
bool
2824

2925
config PCIE_SUPPORT
@@ -39,7 +35,6 @@ config PWM_SUPPORT
3935
bool
4036

4137
config USB_SUPPORT
42-
select AUDIO_SUPPORT
4338
bool
4439

4540
config USB_GADGET_SUPPORT

0 commit comments

Comments
 (0)