fix(consolidator): strip system-reminder blocks before memory extraction

- Added _SYSTEM_REMINDER_RE regex and _strip_system_reminders() to session_consolidator.py
- Applied stripping in extract_conversation_text() for both list and string content types
- Root cause: hooks inject memory YAML/JSON as <system-reminder> blocks in user messages;
  these were fed verbatim to the LLM extractor, producing garbled "Correction:" memories
  containing frontmatter fragments and JSON field names
- Added 3 targeted tests covering text-block, string-content, and multi-reminder cases
- Full suite: 3176 passed, 2 skipped, no regressions

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: lee-fuhr

src/session_consolidator.py

@@ -8,6 +8,7 @@
 """
 
 import json
+import re
 from dataclasses import dataclass, field
 from pathlib import Path
 from typing import Any
@@ -21,6 +22,16 @@
 from .dedup import deduplicate as _deduplicate_memories
 from .dedup import smart_dedup_decision as _smart_dedup_decision
 
+# Strip <system-reminder> blocks injected by hooks — these contain memory YAML/JSON
+# and cause the LLM extractor to produce garbled "corrections"
+_SYSTEM_REMINDER_RE = re.compile(r'<system-reminder>.*?</system-reminder>', re.DOTALL | re.IGNORECASE)
+
+
+def _strip_system_reminders(text: str) -> str:
+    """Remove injected system-reminder blocks before extraction."""
+    return _SYSTEM_REMINDER_RE.sub('', text).strip()
+
+
 # Imported at module level so monkeypatch can target it for tests
 try:
     from .hook_state import get_session_state
@@ -157,17 +168,19 @@ def extract_conversation_text(self, messages: list[dict[str, Any]]) -> str:
                 text_parts = []
                 for block in content:
                     if isinstance(block, dict) and block.get('type') == 'text':
-                        text = block.get('text', '')
+                        text = _strip_system_reminders(block.get('text', ''))
                         if text and not _is_garbage_content(text):
                             text_parts.append(text)
                     elif isinstance(block, str):
-                        if not _is_garbage_content(block):
-                            text_parts.append(block)
+                        cleaned = _strip_system_reminders(block)
+                        if cleaned and not _is_garbage_content(cleaned):
+                            text_parts.append(cleaned)
                 if text_parts:
                     parts.append(f"{role}: {' '.join(text_parts)}")
             elif isinstance(content, str):
-                if not _is_garbage_content(content):
-                    parts.append(f"{role}: {content}")
+                cleaned = _strip_system_reminders(content)
+                if cleaned and not _is_garbage_content(cleaned):
+                    parts.append(f"{role}: {cleaned}")
 
         return "\n\n".join(parts)
 

tests/test_session_consolidator.py

@@ -84,6 +84,69 @@ def test_extract_conversation_text(self, consolidator, sample_session_file):
         assert "client objections" in conversation_text.lower()
         assert "acknowledge their concern" in conversation_text.lower()
 
+    def test_system_reminders_stripped_from_text_blocks(self, consolidator):
+        """system-reminder blocks injected by hooks are stripped before extraction"""
+        real_content = "We should always delegate to specialist agents before executing work ourselves."
+        messages = [
+            {
+                "role": "user",
+                "content": [
+                    {
+                        "type": "text",
+                        "text": (
+                            f"{real_content}\n"
+                            "<system-reminder>\n"
+                            "---\n"
+                            "name: voice preference\n"
+                            "type: feedback\n"
+                            "---\n"
+                            "Never use em-dashes.\n"
+                            "</system-reminder>"
+                        )
+                    }
+                ]
+            }
+        ]
+        result = consolidator.extract_conversation_text(messages)
+        assert "<system-reminder>" not in result
+        assert "name: voice preference" not in result
+        assert "type: feedback" not in result
+        assert real_content in result
+
+    def test_system_reminders_stripped_from_string_content(self, consolidator):
+        """system-reminder stripping works on plain string content too"""
+        real_content = "Always load the voice skill before drafting communications on Lee's behalf."
+        messages = [
+            {
+                "role": "user",
+                "content": (
+                    f"{real_content}\n"
+                    "<system-reminder>injected YAML frontmatter here with type: feedback fields</system-reminder>"
+                )
+            }
+        ]
+        result = consolidator.extract_conversation_text(messages)
+        assert "injected YAML frontmatter here" not in result
+        assert real_content in result
+
+    def test_multiple_system_reminders_stripped(self, consolidator):
+        """Multiple system-reminder blocks all removed"""
+        real_content = "Delegate to the specialist agent before attempting to execute the work directly."
+        messages = [
+            {
+                "role": "user",
+                "content": (
+                    "<system-reminder>first injected block with memory content</system-reminder> "
+                    f"{real_content} "
+                    "<system-reminder>second block: {\"type\": \"correction\", \"content\": \"garbled\"}</system-reminder>"
+                )
+            }
+        ]
+        result = consolidator.extract_conversation_text(messages)
+        assert "first injected block" not in result
+        assert "second block" not in result
+        assert real_content in result
+
     def test_handle_nonexistent_session(self, consolidator):
         """Handle missing session file gracefully"""
         with pytest.raises(FileNotFoundError):