Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The code will be very slow. #24

Open
StefanIsSmart opened this issue Apr 19, 2024 · 1 comment
Open

The code will be very slow. #24

StefanIsSmart opened this issue Apr 19, 2024 · 1 comment

Comments

@StefanIsSmart
Copy link

You use the for-loop for multi-head. (Time x The Number of Heads)
And also use the for-loop for Graph attention. (Time x The Number of Graph)

It will be very slow.

Is there any other way to solve that point ?
@leffff
Copy link
Owner

leffff commented Apr 25, 2024

Not sure yet!
I believe the best way is to

  1. Rewrite it to classic mutlihead attentinon
  2. Rewrite "1)" to PyG-like attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leffff @StefanIsSmart