Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure client side code according to which panel it belongs to #6

Open
2 tasks
dexmona opened this issue Feb 27, 2019 · 0 comments
Open
2 tasks

Restructure client side code according to which panel it belongs to #6

dexmona opened this issue Feb 27, 2019 · 0 comments
Labels
Good first issue Good for newcomers Refactor

Comments

@dexmona
Copy link
Contributor

dexmona commented Feb 27, 2019 •
edited
Loading

Currently our JS is scattered among various source files that only vaguely represent the client side's structure.
Also, panel-specific code should check if its panel is present (document.getElementById("the-panel-s-id") returns the element) and only continue if it is, instead of throwing errors.

  • Move panel-specific functions into files respecting the panel structure (eg. one file for one panel)
  • Only run something if it has to do with the current page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Good for newcomers Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dexmona