Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListViews #3

Open
cdlewis opened this issue May 17, 2015 · 4 comments
Open

ListViews #3

cdlewis opened this issue May 17, 2015 · 4 comments

Comments

@cdlewis
Copy link
Contributor

cdlewis commented May 17, 2015

The readme mentions that this is for listviews as well as scrollviews, I was kinda curious about how this would work. If you nest the listview inside the parallax-view then onEndReached doesn't fire. If you change the scrollview to a listview in the source code then the header no longer shows up properly.

Is there something really obvious I'm missing?

@lelandrichardson
Copy link
Owner

@cdlewis I think this was me just writing nonsense :?

I think I was initially going down a path where it would work for both but just ended up with a scrollview. This would be a really nice thing to support though since this would be a pretty common use case.

i think in order to support this the right approach would be to selectively use a ListView or a ScrollView, rather than just have ScrollView hard coded.

This sounds like what you did and it worked other than the header shows up incorrectly? Perhaps you could post a screenshot of how the header shows up? This could be related to the contentInset prop.

I'll try to refactor so that there is a ParallaxScrollView and ParallaxListView or something like that.

@irfaan
Copy link

irfaan commented Aug 29, 2015

+1 - Do you have a working copy of the changes necessary to use the forthcoming ParallaxListView?

@waleedarshad-vf
Copy link

+1

1 similar comment
@Naoto-Ida
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants