Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN 0.49.3 broken change #57

Open
douglaswissett opened this issue Oct 13, 2017 · 2 comments · May be fixed by #58
Open

RN 0.49.3 broken change #57

douglaswissett opened this issue Oct 13, 2017 · 2 comments · May be fixed by #58

Comments

@douglaswissett
Copy link

Hi there!

Upgraded to RN0.49.3 and getting node_module bugs.

in file React-native-parallax-view/parallaxView.js
I needed to add const PropTypes = require('prop-types')
const createReactClass = require('create-react-class');

Replace React.PropTypes with PropTypes
replace React.createClass with createReactClass

Appreciate any help on this issue.

Thanks!
@vzaffalon
Copy link

vzaffalon commented Oct 13, 2017 •
edited
Loading

same problem here getting undefined is not an object(evaluating 'React.PropTypes.number') solved downloading the file and doing what douglas said

@Paul-Lategan
Copy link

Same problem, fix worked for me too. Thanks Douglas.

parndt added a commit to cvcnetwork/react-native-parallax-view that referenced this issue Oct 23, 2017
@parndt
Import PropTypes and createReactClass
7e5ebde 
This relates to a breaking change in React 16

Fixes lelandrichardson#57
Fixes lelandrichardson#56
@parndt parndt linked a pull request Oct 23, 2017 that will close this issue
Open
parndt added a commit to cvcnetwork/react-native-parallax-view that referenced this issue Oct 23, 2017
@parndt
Import PropTypes and createReactClass
206f14c 
This relates to a breaking change in React 16 where PropTypes and
createClass were removed from React

Fixes lelandrichardson#57
Fixes lelandrichardson#56
@poberwong poberwong mentioned this issue Nov 16, 2017
Merged
@allanwgithub allanwgithub mentioned this issue Mar 19, 2019
Merged
allanwgithub added a commit to cvcnetwork/react-native-parallax-view that referenced this issue Mar 19, 2019
@allanwgithub
Merge pull request #1 from cvcnetwork/react-native-0-49-3
8f13017 
This relates to a breaking change in React 16 where PropTypes and
createClass were removed from React

Fixes lelandrichardson#57
Fixes lelandrichardson#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Import PropTypes and createReactClass cvcnetwork/react-native-parallax-view
3 participants
@Paul-Lategan @vzaffalon @douglaswissett