Bind for peek-legit-discard-file conflicts with vi-mode

[ghosty141]

Because of this keybind you can't navigate in normal mode in legit which makes it kind of unusable.

(define-key *peek-legit-keymap* "k" 'peek-legit-discard-file)

[g-gundam]

I've encountered quite a few modes where vi-mode feels like a second class citizen.

• color-theme-selector-mode
• dashboard-mode
• legit
• filer

Who knows what else. They make you go into vi insert-mode to do anything.

[vindarel]

yeah… those issues are not fun. My "fix" would be to ensure we enter Legit in Emacs mode or vi insert mode, so we don't have the conflicts.

[g-gundam]

There has to be a better way. If Emacs can do it, why not Lem? I'm going to keep thinking about it.

[ghosty141]

yeah… those issues are not fun. My "fix" would be to ensure we enter Legit in Emacs mode or vi insert mode, so we don't have the conflicts.

I don't fully agree. For VI users normal mode/motion mode is the standard so that should be honored even in 3rd party packages.

For "discard" I'd suggest "x" as that would work with vi-mode in normal just fine! Magit also uses that I believe

[g-gundam]

Take a look at #1515. I didn't do anything for legit yet, but I could. I just chose to fix some of the simpler modes first as a proof of concept.