Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use led_color for leds instead of screen_color #49

Closed
lemeryfertitta opened this issue Feb 15, 2024 · 3 comments · Fixed by #51
Closed

Use led_color for leds instead of screen_color #49

lemeryfertitta opened this issue Feb 15, 2024 · 3 comments · Fixed by #51
Assignees
@lemeryfertitta
Labels
bug Something isn't working feature parity This feature exists in the official apps

Comments

@lemeryfertitta
Copy link
Owner

lemeryfertitta commented Feb 15, 2024 •
edited
Loading

From #45
@lemeryfertitta lemeryfertitta added bug Something isn't working feature parity This feature exists in the official apps labels Feb 15, 2024
@lemeryfertitta lemeryfertitta self-assigned this Feb 15, 2024
@lemeryfertitta lemeryfertitta linked a pull request Feb 15, 2024 that will close this issue
Use led_colors #51
Merged
@gardaholm
Copy link
Contributor

this version is not yet deployed I guess?
had a quick session in the afternoon here and the colors are still off.

@lemeryfertitta
Copy link
Owner Author

this version is not yet deployed I guess? had a quick session in the afternoon here and the colors are still off.

Ah yes, forgot to deploy! Going to do a quick PR to remove the arrows then will deploy everything

@lemeryfertitta
Copy link
Owner Author

@gardaholm LED colors should be deployed now, decided to hold off on arrow removal as I wanted to wrap in a couple of other improvements with that refactor. Let me know if they still seem off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemeryfertitta lemeryfertitta

Labels
bug Something isn't working feature parity This feature exists in the official apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use led_colors lemeryfertitta/Climbdex
2 participants
@lemeryfertitta @gardaholm