Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message on API error #62

Closed
lemeryfertitta opened this issue Apr 26, 2024 · 4 comments
Closed

Show error message on API error #62

lemeryfertitta opened this issue Apr 26, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lemeryfertitta
Copy link
Owner

The search results page will seem like its loading when the search API has actually returned an error. For example:

https://climbdex.com/results?minGrade=undefined&maxGrade=undefined&name=&angle=any&minAscents=1&sortBy=ascents&sortOrder=desc&minRating=1.0&onlyClassics=0&gradeAccuracy=1&settername=&holds=&mirroredHolds=&board=kilter&layout=1&size=8&set=1&set=20&roleMatch=strict

It would be more useful if there was an error message, possibly with a link to report the issue here.

@lemeryfertitta lemeryfertitta added enhancement New feature or request good first issue Good for newcomers labels Apr 26, 2024
@brmnjsh
Copy link

brmnjsh commented May 3, 2024

PR created adding parameter validations as well as toast messages for errors

@lemeryfertitta Since we're swallowing errors, I wanted to inquire about logging. Do we have a particular location/strategy we'd want to approach this with (logging service and/or local server based)?

@lemeryfertitta
Copy link
Owner Author

@brmnjsh thanks for the PR!

Good question about logging. I hadn't really thought about setting up anything robust yet. I think given the very low number of users currently, I'd just stick with outputting to the console, assuming that's what you mean by local server based. I'm able to get the console output in my fly.io dashboard, so I can generally use that for debugging and such. There are probably a few other features that are higher priority to make Climbdex a better drop-in replacement for the existing apps before more robust logging becomes a priority, but it would eventually be a nice thing to have.

@brmnjsh
Copy link

brmnjsh commented May 3, 2024

@lemeryfertitta alright! I'll log to console for now.

lemeryfertitta added a commit that referenced this issue May 13, 2024
@lemeryfertitta
Copy link
Owner Author

Deployed! Thanks again, @brmnjsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants