Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup params in back link when not using history.back() #66

Open
lemeryfertitta opened this issue May 6, 2024 · 0 comments
Open

Cleanup params in back link when not using history.back() #66

lemeryfertitta opened this issue May 6, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lemeryfertitta
Copy link
Owner

Discussed in #65 (comment)

When using the "back to filter selection" link in the case where history.back is not used (e.g. a shared search result) we populate the filter page URL with all of the current params. Most of these params are invalid for that URL, so we should likely just trim this to contain only the relevant params.

This is only a small cosmetic cleanup, so probably not a super high priority, but should be an easy fix.

@lemeryfertitta lemeryfertitta added bug Something isn't working good first issue Good for newcomers labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant