Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution of script rsmooth as a function is not supported: #4

Open
mhamilt opened this issue Jun 7, 2024 · 3 comments
Open

Execution of script rsmooth as a function is not supported: #4

mhamilt opened this issue Jun 7, 2024 · 3 comments

Comments

@mhamilt
Copy link

mhamilt commented Jun 7, 2024

Somewhere in between MATLAB 2021b and 2023b there is the following error

Execution of script rsmooth as a function is not supported:
path/to/matlab/yin/private/rsmooth.m

This is true for both windows and macOS versions. The MacBook used was arm64, the windows machine is x86_64

@mhamilt
Copy link
Author

mhamilt commented Jun 7, 2024

Problem seemed to relate to the precompiled .mex binaries., Solution for us was to recompile for arm64.

From the top level of the repository

mex yin/private/src/cumnorm_inplace.c -R2018a -outdir yin/private
mex yin/private/src/interp_inplace.c -R2018a -outdir yin/private
mex yin/private/src/rdiff_inplace.c -R2018a -outdir yin/private
mex yin/private/src/dftoperiod.c -R2018a -outdir yin/private
mex yin/private/src/mininrange.c -R2018a -outdir yin/private
mex yin/private/src/rsmooth.c -R2018a -outdir yin/private
mex yin/private/src/dftoperiod2.c -R2018a -outdir yin/private
mex yin/private/src/minparabolic.c -R2018a -outdir yin/private
mex yin/private/src/rsum_inplace.c -R2018a -outdir yin/private

Could be added as part of the startup, but that will obviously open up problems where the compilation fails.

@lemonzi
Copy link
Owner

lemonzi commented Jul 25, 2024

Oops, I haven't used this code in years. I don't remember where I got the Yin codebase from but, if this has become the de-facto source, I'd be happy to accept a pull request with the updated binaries.

@mhamilt mhamilt mentioned this issue Aug 23, 2024
@mhamilt
Copy link
Author

mhamilt commented Aug 23, 2024

YIN was available directly from IRCAM, but the links no longer work. I couldn't find a repo from IRCAM or Alain de Cheveigné online, so I made a mirror with some extra notes:

https://github.com/mhamilt/yin

I think best practice would have the compiled binaries in a release and some kind of "make" script in source so I will hold off with a pull request for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants