Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to make sure all filters, order and sorting works #112

Open
lenguyenthanh opened this issue May 28, 2024 · 0 comments
Open

Add tests to make sure all filters, order and sorting works #112

lenguyenthanh opened this issue May 28, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lenguyenthanh
Copy link
Owner

lenguyenthanh commented May 28, 2024 •
edited
Loading

To verify query like

curl -X 'GET' \
  'http://localhost:9669/api/players?sort_by=year' \
  -H 'accept: application/json'

Which was broken before #115. We need to add tests that cover all possible filters to make sure this never happen again.
@lenguyenthanh lenguyenthanh added bug Something isn't working good first issue Good for newcomers labels May 28, 2024
@lenguyenthanh lenguyenthanh changed the title Fix internal server error when order by birth year Add tests to make sure all filters, order and sorting works May 28, 2024
@lenguyenthanh lenguyenthanh added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lenguyenthanh