Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dunner Unit tests in windows fail #178

Closed
apoorvam opened this issue Aug 31, 2019 · 1 comment
Closed

Dunner Unit tests in windows fail #178

apoorvam opened this issue Aug 31, 2019 · 1 comment
Labels
bug Something isn't working windows Windows OS

Comments

@apoorvam
Copy link
Collaborator

Ref: https://github.com/leopardslab/dunner/pull/165/checks?check_run_id=208911721

11 unit tests of dunner fail on windows. Mostly related to path issues.

Expected

Unit tests should pass on dunner
@apoorvam apoorvam added windows Windows OS bug Something isn't working labels Aug 31, 2019
@apoorvam apoorvam changed the title Dunenr Unit tests in windows fail Dunner Unit tests in windows fail Aug 31, 2019
apoorvam added a commit that referenced this issue Aug 31, 2019
@apoorvam
Get User home dir from go to make OS friendly | Fix some windows tests …
faaa0ff 
…#178
@apoorvam
Copy link
Collaborator Author

apoorvam commented Sep 5, 2019

Have made all the tests to work based on OS and not linux specific as part of PR: #165

However, there are two tests failing which are due to implementation issue with way mount directory can be defined in Dunner file. Will open a new issue for that and close this.

@apoorvam apoorvam closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working windows Windows OS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apoorvam