Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error when running the test when the site is offline - travis #222

Open
avelino opened this issue Oct 15, 2020 · 0 comments
Open

error when running the test when the site is offline - travis #222

avelino opened this issue Oct 15, 2020 · 0 comments

Comments

@avelino
Copy link
Contributor

avelino commented Oct 15, 2020

If you make a new contribution (pull request) and have an offline (-a 503,405,406,401,403,301,302) site the test will not pass, even if the site that is added is online.

We should test the link that is being added

To validate the links that are in the readme we can create a scheduled job in GitHub that does this validation and opens issue automatically if any link does not pass the test, ex: https://github.com/avelino/awesome-go/blob/master/.github/workflows/run-check.yaml#L19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avelino