Skip to content

Commit a89a461

Browse files
authored
Merge branch 'main' into multiplat
2 parents 33ad853 + 58f02cd commit a89a461

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

va/caa.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,11 @@ func filterCAA(rrs []*dns.CAA) ([]*dns.CAA, []*dns.CAA, bool) {
202202
// do not store the contents of the property tag, but also avoid setting
203203
// the criticalUnknown bit if there are critical iodef tags.
204204
continue
205-
case "issuemail":
206-
// We support the issuemail property tag insofar as we recognize it and
207-
// therefore do not bail out if someone has a critical issuemail tag. But
205+
case "issuemail", "issuevmc":
206+
// We support these property tags insofar as we recognize them and
207+
// therefore do not bail out if someone has one marked critical. But
208208
// of course we do not do any further processing, as we do not issue
209-
// S/MIME certificates.
209+
// S/MIME or VMC certificates.
210210
continue
211211
default:
212212
// The critical flag is the bit with significance 128. However, many CAA

va/caa_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,6 +1163,7 @@ func TestFilterCAA(t *testing.T) {
11631163
{Tag: "issuewild", Value: "b"},
11641164
{Tag: "iodef", Value: "c"},
11651165
{Tag: "issuemail", Value: "c"},
1166+
{Tag: "issuevmc", Value: "c"},
11661167
},
11671168
expectedIssueVals: []string{"a"},
11681169
expectedWildVals: []string{"b"},
@@ -1174,6 +1175,7 @@ func TestFilterCAA(t *testing.T) {
11741175
{Tag: "issuewild", Value: "b", Flag: 128},
11751176
{Tag: "iodef", Value: "c", Flag: 128},
11761177
{Tag: "issuemail", Value: "c", Flag: 128},
1178+
{Tag: "issuevmc", Value: "c", Flag: 128},
11771179
},
11781180
expectedIssueVals: []string{"a"},
11791181
expectedWildVals: []string{"b"},

0 commit comments

Comments
 (0)