-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default nodeJS 18.18.0 #441
Comments
@Eschults I don't think updating node would be a bad idea at all. In terms of technically doing it in the setup guide, it'd be quite easy. But how do you feel about us doing such an update? |
Hello @ajdubovoy 👋 We definitely should, the recommended LTS version is now Besides challenges, this change impacts a lot of boilerplates / livecodes repositories, both in the @lewagon org and in the @lewagon-assess org for the French certification exam. Let's start by creating PR using the same branch name convention for all repos, and we can decide later how we plan to release the change 🚀 |
Sounds good! But also sounds like quite a huge project unless I'm misunderstanding. I'm happy to take it on, but is there any sense in us coming up with a strategy beforehand? Or is it better if I just dive into all the repos and see if anything breaks when I upgrade....? |
Also I don't think I have access to @lewagon-assess |
Let's start by identifying the repos that need a change in the ✅ I granted you access to @lewagon-assess |
Sounds good. Hm, yeah I doubt the JS update will break anything tbh since the students barely use Thank you! |
@nguiban just looping you in here as well 🚀 |
Hello ! |
Also works for me! Nothing is breaking because of this, it's just maintenance we need to eventually do |
@ajdubovoy @Eschults Just a heads up that but Webpack 4 is not compatible with Node 17+ because Node has migrated to OpenSSL3 but it still relies on legacy ssl protocols. It's still possible to use a webpack 4 command by exporting the Back in my by batch we had a couple slides about how Webpack is the industry standard and that's why LeWagon is still sticking to it (if that's still what you want then bump to v5) but as far as frontend development goes Vite has really become the golden standard in any project that can use it. It's also easier to setup for you and easier to understand for the students so imo LeWagon should drop Webpack completely (which you have already done for Rails after switching to importmaps) and go with Vite instead if a bundler is still needed at all |
Hi @wJoenn as far as I'm aware we've fully dropped Webpack from the curriculum already and use no-build setups in the entire front end unit and in Rails 😊 |
It's still inside the frontend unit's package.json |
We could probably remove it because it's never used in a challenge |
On September 11, 2023, NodeJS 16 was discontinued and will no longer receive support or security updates.
Update the kitt material to install the latest stable LTS version of NodeJS, which is version 18.18.0
The text was updated successfully, but these errors were encountered: