get-deps: fill REL_HASH_* from linuxkit

otherwise get-deps cannot detect dependencies

Signed-off-by: Christoph Ostarek <[email protected]>

Author: christoph-zededa

tools/get-deps/lktargs.go

@@ -0,0 +1,133 @@
+package main
+
+import (
+	"context"
+	"errors"
+	"io"
+	"os"
+	"path/filepath"
+
+	"github.com/linuxkit/linuxkit/src/cmd/linuxkit/pkglib"
+	"github.com/linuxkit/linuxkit/src/cmd/linuxkit/spec"
+	buildkitClient "github.com/moby/buildkit/client"
+	imagespec "github.com/opencontainers/image-spec/specs-go/v1"
+)
+
+const (
+	defaultPkgBuildYML  = "build.yml"
+	defaultPkgCommit    = "HEAD"
+	defaultPkgTag       = "{{.Hash}}"
+	defaultBuilderImage = "moby/buildkit:v0.12.3"
+)
+
+// heavily inspired by src/cmd/linuxkit/pkglib/dockerdryrun.go
+type buildArgsDockerRunner struct {
+	buildArgs map[string]string
+}
+
+func (dr *buildArgsDockerRunner) Builder(
+	ctx context.Context,
+	dockerContext, builderImage, builderConfigPath, platform string,
+	restart bool,
+) (*buildkitClient.Client, error) {
+	return nil, nil
+}
+
+func (dr *buildArgsDockerRunner) Pull(img string) (bool, error) {
+	return false, errors.New("not implemented")
+}
+
+func (dr *buildArgsDockerRunner) Tag(ref, tag string) error {
+	return errors.New("not implemented")
+}
+
+func (dr *buildArgsDockerRunner) Build(
+	ctx context.Context,
+	tag, pkg, dockerContext, builderImage, builderConfigPath, platform string,
+	restart, preCacheImages bool,
+	c spec.CacheProvider,
+	r io.Reader,
+	stdout io.Writer,
+	sbomScan bool,
+	sbomScannerImage, platformType string,
+	imageBuildOpts spec.ImageBuildOptions,
+) error {
+	for k, v := range imageBuildOpts.BuildArgs {
+		dr.buildArgs[k] = *v
+	}
+
+	return nil
+}
+
+func (dr *buildArgsDockerRunner) Save(tgt string, refs ...string) error {
+	return errors.New("not implemented")
+}
+
+func (dr *buildArgsDockerRunner) Load(src io.Reader) error {
+	return errors.New("not implemented")
+}
+
+func (dr *buildArgsDockerRunner) ContextSupportCheck() error {
+	return nil
+}
+
+func lktBuildArgs(ymlPath string) map[string]string {
+
+	ymlBuildFile := filepath.Base(ymlPath)
+
+	pkglibConfig := pkglib.PkglibConfig{
+		BuildYML:   ymlBuildFile,
+		HashCommit: defaultPkgCommit,
+		Dev:        false,
+		Tag:        defaultPkgTag,
+	}
+	pkgs, err := pkglib.NewFromConfig(pkglibConfig, filepath.Dir(ymlPath))
+	if err != nil {
+		panic(err)
+		// silently ignore that this is not a linuxkit package
+	}
+
+	var opts []pkglib.BuildOpt
+
+	badr := &buildArgsDockerRunner{
+		buildArgs: map[string]string{},
+	}
+
+	opts = append(opts, pkglib.WithBuildDocker(badr))
+	opts = append(opts, pkglib.WithDryRun())
+	tmpDir := os.TempDir()
+	defer os.RemoveAll(tmpDir)
+	opts = append(opts, pkglib.WithBuildCacheDir(tmpDir))
+	opts = append(opts, pkglib.WithBuildSbomScanner("")) // but why?
+	opts = append(opts, pkglib.WithBuildBuilderImage(defaultBuilderImage))
+	opts = append(opts, pkglib.WithBuildBuilderRestart(false))
+	opts = append(opts, pkglib.WithProgress("auto"))
+
+	for _, pkg := range pkgs {
+		plats := []imagespec.Platform{{OS: TARGETOS, Architecture: TARGETARCH}}
+
+		var (
+			pkgPlats = make([]imagespec.Platform, len(plats))
+		)
+		copy(pkgPlats, plats)
+		// unless overridden, platforms are specific to a package, so this needs to be inside the for loop
+
+		// if there are no platforms to build for, do nothing.
+		// note that this is *not* an error; we simply skip it
+		if len(pkgPlats) == 0 {
+			// fmt.Printf("Skipping %s with no architectures to build\n", p.Tag())
+			continue
+		}
+
+		opts = append(opts, pkglib.WithBuildPlatforms(pkgPlats...))
+
+		pkg.ProcessBuildArgs()
+
+		err := pkg.Build(opts...)
+		if err != nil {
+			panic(err)
+		}
+	}
+
+	return badr.buildArgs
+}

tools/get-deps/main.go

@@ -5,9 +5,9 @@ package main
 
 import (
 	"bytes"
+	"errors"
 	"flag"
 	"fmt"
-	"io"
 	"log"
 	"os"
 	"os/exec"
@@ -99,9 +99,13 @@ func (aeg *argsEnvGetter) Keys() []string {
 	return keys
 }
 
-func parseDockerfile(f io.Reader) []string {
-	dt, err := io.ReadAll(f)
+func parseDockerfile(pkgName string) []string {
+	dockerfilePath := filepath.Join(pkgName, "Dockerfile")
+	dt, err := os.ReadFile(dockerfilePath)
 	if err != nil {
+		if errors.Is(err, os.ErrNotExist) {
+			return []string{}
+		}
 		panic(err)
 	}
 
@@ -111,19 +115,38 @@ func parseDockerfile(f io.Reader) []string {
 	}
 	stages, metaArgs, err := instructions.Parse(dockerfile.AST, nil)
 	if err != nil {
-		panic(err)
+		log.Fatalf("parsing instructions of %s failed: %v", dockerfilePath, err)
+	}
+
+	aeg := createDockerEnvGetter(filepath.Join(pkgName, "build.yml"), metaArgs)
+
+	shlex := shell.NewLex(dockerfile.EscapeToken)
+
+	targetsMap := make(map[string]struct{})
+	for _, st := range stages {
+		pResult, err := shlex.ProcessWordWithMatches(st.BaseName, &aeg)
+		if err != nil {
+			panic(err)
+		}
+		targetsMap[pResult.Result] = struct{}{}
+	}
+	targets := make([]string, 0)
+	for target := range targetsMap {
+		targets = append(targets, target)
 	}
+	return targets
+}
 
+func createDockerEnvGetter(buildYmlFile string, metaArgs []instructions.ArgCommand) argsEnvGetter {
 	buildPlatform := []ocispecs.Platform{platforms.DefaultSpec()}[0]
 	targetPlatform := ocispecs.Platform{
 		Architecture: TARGETARCH,
 		OS:           TARGETOS,
 		Variant:      TARGETVARIANT,
 	}
 
-	// from github.com/moby/buildkit/frontend/dockerfile/dockerfile2llb/platform.go:getPlatformArgs
 	aeg := argsEnvGetter{
-		// args: map[string]string{},
+		// from github.com/moby/buildkit/frontend/dockerfile/dockerfile2llb/platform.go:getPlatformArgs
 		args: map[string]string{
 			"BUILDPLATFORM":  platforms.Format(buildPlatform),
 			"BUILDOS":        buildPlatform.OS,
@@ -143,21 +166,11 @@ func parseDockerfile(f io.Reader) []string {
 		}
 	}
 
-	shlex := shell.NewLex(dockerfile.EscapeToken)
-
-	targetsMap := make(map[string]struct{})
-	for _, st := range stages {
-		pResult, err := shlex.ProcessWordWithMatches(st.BaseName, &aeg)
-		if err != nil {
-			panic(err)
-		}
-		targetsMap[pResult.Result] = struct{}{}
+	for k, v := range lktBuildArgs(buildYmlFile) {
+		aeg.args[k] = v
 	}
-	targets := make([]string, 0)
-	for target := range targetsMap {
-		targets = append(targets, target)
-	}
-	return targets
+
+	return aeg
 }
 
 // Print a single dependency package, only suitable for dot file
@@ -243,15 +256,8 @@ func filterPkg(deps []string) []string {
 }
 
 // Return a list of all dependencies (packages) listed in a Dockerfile
-func getDeps(dockerfile string) []string {
-	var depList []string
-	f, err := os.Open(dockerfile)
-	if err != nil {
-		fmt.Println(err)
-		return depList
-	}
-	defer f.Close()
-	ss := parseDockerfile(f)
+func getDeps(pkgName string) []string {
+	ss := parseDockerfile(pkgName)
 
 	return filterPkg(ss)
 }
@@ -347,7 +353,7 @@ func main() {
 
 		// Get package dependencies from Dockerfile
 		writeToFile(outfile, p.printSingleDep(pkgName))
-		depList := getDeps(dockerFile)
+		depList := getDeps(pkgName)
 		for _, d := range depList {
 			if d != pkgName {
 				// Write a single dependency of the package