Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac&i feeds items with broken img tag #33

Open
aschilling opened this issue Jul 29, 2016 · 3 comments
Open

Mac&i feeds items with broken img tag #33

aschilling opened this issue Jul 29, 2016 · 3 comments

Comments

@aschilling
Copy link

Hi,

first of all. Thank you for your great work, I rely on rss extender every day and it works great so far. Unfortunately, the img tags from heise posts (especiall from mac&i) are not closed anymore and thus dont work.
Can you reproduce the issue?

Thanks in advance.

Andy

@Strubbl
Copy link
Collaborator

Strubbl commented Aug 1, 2016

The image tags do not need to be closed, don't they? Or what do you mean by closing?

I do not use this feed in my rss reader, so by looking only at the rss feed source code from rss-extender i cannot see an issue. Can you please pick a concrete example from a recent article?

@aschilling
Copy link
Author

Hi,

I looked at the issue over the weekend and I think I found the problem. In particular, it is a problem for many feedreaders if an image path begins with "//". As soon as I replaced "//" with "https://". images were successfully displayed.

However, the issue does not only occur with images in the heise feed but also in other feeds. Thus, I think a global search and replace rule would be most appropriate.

What do you think?

Cheers

Andy

@Strubbl
Copy link
Collaborator

Strubbl commented Aug 8, 2016

Sounds reasonable to me. Can you please create a pull request with a proposal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants