Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Separate load and play for VideoLoader #98

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: Separate load and play for VideoLoader #98

wants to merge 6 commits into from

Conversation

SimonIT
Copy link
Member

@SimonIT SimonIT commented Dec 25, 2024

@Frosty-J @dasisdormax As you guys have most interacted with it (I think), what's your opinion?

@dasisdormax
Copy link
Contributor

Thanks for your work on this feature.

About the VideoLoader:
I assume this is meant to be used with the libGDX AssetManager? If so, I don't personally need it but I think it will be useful for other users. Please correct me if I'm wrong.

About the separated load and play:
I couldn't do much testing so far, but looking at the code the changes look good to me.

Looking at the pause functions, I noticed that the playRequested flags are set and reset differently between platforms. Without looking in detail, I think this may break the play / pause workaround that I used previously.

I personally am fine with breaking this workaround, as long as we update the README as well.

@SimonIT
Copy link
Member Author

SimonIT commented Dec 26, 2024

Thanks for taking a look!

About the VideoLoader

Correct

About the separated load and play

I changed the readme. I might also have fixed your workaroud, but not sure. Can you try and give some feedback if you have time? Especially iOS since I can't test it.

@SimonIT SimonIT linked an issue Dec 26, 2024 that may be closed by this pull request
Videos cannot be loaded without playing #74
Open
Frosty-J
Frosty-J reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@Frosty-J Frosty-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I hadn't read AbstractVideoPlayer properly. Great stuff.

gdx-video-gwt/src/com/badlogic/gdx/video/VideoPlayerGwt.java Show resolved Hide resolved
gdx-video/src/com/badlogic/gdx/video/assets/VideoLoader.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frosty-J Frosty-J Frosty-J left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Videos cannot be loaded without playing
3 participants
@SimonIT @dasisdormax @Frosty-J