Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rugged::Repository#clone_at :upstream option has no effect #970

Open
fauno opened this issue Sep 12, 2023 · 2 comments
Open

Rugged::Repository#clone_at :upstream option has no effect #970

fauno opened this issue Sep 12, 2023 · 2 comments

Comments

@fauno
Copy link

fauno commented Sep 12, 2023

According to docs

:remote
The name to give to the “origin” remote. Defaults to "origin".

But doesn't produce any results. I've tested this with rugged 1.4.4, 1.5.3, 1.6.3 and 1.7.1:

require 'rugged'
Rugged::Repository.clone_at('../repo', 'fork', remote: 'upstream')
git -C fork remote -v
origin ../repo (fetch)
origin ../repo (push)

Shouldn't "origin" be named "upstream"? I would expect it to work like git clone --origin upstream ../repo fork

@fauno
Copy link
Author

fauno commented Sep 12, 2023

I'm using Alpine (musl) with included libgit2

@fauno
Copy link
Author

fauno commented Sep 12, 2023

Seems to have been removed here:

libgit2/libgit2@1697cd6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant