From 646baa93edcf50a150ab81531231f5fa0e248ae0 Mon Sep 17 00:00:00 2001 From: Guillaume Michel Date: Fri, 7 Feb 2025 16:32:39 +0100 Subject: [PATCH] fix flaky TestSkipRefreshOnGapCpls (#1021) --- rtrefresh/rt_refresh_manager_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/rtrefresh/rt_refresh_manager_test.go b/rtrefresh/rt_refresh_manager_test.go index 994e0d1ac..e214c4c1c 100644 --- a/rtrefresh/rt_refresh_manager_test.go +++ b/rtrefresh/rt_refresh_manager_test.go @@ -15,8 +15,6 @@ import ( ) func TestSkipRefreshOnGapCpls(t *testing.T) { - t.Skip("This test is flaky, see https://github.com/libp2p/go-libp2p-kad-dht/issues/722.") - ctx, cancel := context.WithCancel(context.Background()) defer cancel() local := test.RandPeerIDFatal(t) @@ -40,6 +38,10 @@ func TestSkipRefreshOnGapCpls(t *testing.T) { p, err := rt.GenRandPeerID(uint(u)) require.NoError(t, err) + for rt.Find(p) != "" { + p, err = rt.GenRandPeerID(uint(u)) + require.NoError(t, err) + } b, err := rt.TryAddPeer(p, true, false) require.NoError(t, err) require.True(t, b)