Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run interop tests across libp2p versions #1107

Closed
Stebalien opened this issue May 20, 2021 · 4 comments
Closed

Run interop tests across libp2p versions #1107

Stebalien opened this issue May 20, 2021 · 4 comments

Comments

@Stebalien
Copy link
Member

When testing PRs, we should test the current branch against master (or the last release?) in an interop test to make sure we don't break backwards compatibility. We should be able to use the existing interop tests to do this.

Additionally, we should test this in all configurations:

  • TCP, QUIC, WS.
  • TCP+TLS, TCP+Noise
  • TCP+Noise+Yamux, TCP+Noise+Mplex

Unfortunately, at a minimum that'll give us 5 test runs (which can luckily be done concurrently).

@BigLep
Copy link
Contributor

BigLep commented Aug 20, 2021

@Stebalien : to confirm, today we have interop tests that go between go-libp2p and js-libp2p and this is about adding some go-libp2p to go-libp2p with different configurations. You mentioned 5 test runs. To be clear, can you enumerate what the 5 combinations are?

Also, some pointers on where to make changes would be great (interop repo?)

@Stebalien
Copy link
Member Author

Hm. Should have written that down. Probably:

  1. QUIC
  2. TCP+TLS+Yamux (go)
  3. TCP+Noise+Yamux (rust)
  4. TCP+Noise+Mplex (js/rust)
  5. WS+Noise+Mplex (js)

That should cover it.

@BigLep BigLep added this to go-libp2p Apr 26, 2022
@BigLep BigLep moved this to 🥞 Todo in go-libp2p Aug 12, 2022
@BigLep BigLep added this to the Best Effort Track milestone Aug 26, 2022
@p-shahi
Copy link
Member

p-shahi commented Oct 13, 2022

Relates to libp2p/test-plans#44

@p-shahi p-shahi removed this from the Best Effort Track milestone Nov 8, 2022
@p-shahi
Copy link
Member

p-shahi commented Nov 8, 2022

closing in favor of libp2p/test-plans#61

@p-shahi p-shahi closed this as completed Nov 8, 2022
Repository owner moved this from 🥞 Todo to 🎉 Done in go-libp2p Nov 8, 2022
@p-shahi p-shahi removed this from go-libp2p Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants